Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Shared: Fix issues with local Proof of Work #1214

Merged
merged 2 commits into from
Mar 27, 2019
Merged

Shared: Fix issues with local Proof of Work #1214

merged 2 commits into from
Mar 27, 2019

Conversation

cvarley100
Copy link
Contributor

@cvarley100 cvarley100 commented Mar 26, 2019 •
edited
Loading

Description

  • Fixes bundle traversal validation
  • Fixes incorrect bundle order

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested on iOS

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@rajivshah3 rajivshah3 added C - Shared E - Functional Epic - Relating to how a feature works T - Bug Type - Bug: Something isn't working labels Mar 26, 2019
rajivshah3
rajivshah3 approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@rajivshah3 rajivshah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on desktop as well

@laumair laumair self-requested a review March 27, 2019 14:27
@cvarley100 cvarley100 merged commit 19a7b88 into feat/isBundle Mar 27, 2019
@rajivshah3 rajivshah3 mentioned this pull request Mar 27, 2019
Merged
@rajivshah3 rajivshah3 deleted the bug/local-pow branch March 27, 2019 16:30
cvarley100 added a commit that referenced this pull request Mar 27, 2019
@cvarley100
Shared: Add isBundle for validating bundle semantics in correct trans…
1ae23e5 
…action order (#1213)

* Resolve conflicts

* Shared: Fix issues with local Proof of Work (#1214)

* Shared: Fix order for bundles constructed with local PoW

* Shared: Fix bundle traversal validation check
@cvarley100 cvarley100 mentioned this pull request May 7, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laumair laumair laumair approved these changes

@rajivshah3 rajivshah3 rajivshah3 approved these changes

Assignees
No one assigned
Labels
C - Shared E - Functional Epic - Relating to how a feature works T - Bug Type - Bug: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvarley100 @rajivshah3 @laumair