This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Fix promotion & reattachment alert issue #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvarley100
approved these changes
May 29, 2019
cvarley100
approved these changes
May 29, 2019
cvarley100
pushed a commit
that referenced
this pull request
May 30, 2019
rihardsgravis
pushed a commit
that referenced
this pull request
May 31, 2019
* desktop-0.6.0: (92 commits) Shared: Fix remote node list and out of sync alerts (#1672) Mobile: Fix crashes/behaviour on node settings Desktop linting fixes Bump version and update Changelog to `0.6.0-RC1` Update failing tests Deskop 0.5.2 release (#1656) Bump react-transition-group from 4.0.1 to 4.1.0 in /src/desktop (#1663) Temporary disable custom node authorisation entry Desktop `0.5.2` version bump (#1668) Bump snyk from 1.169.2 to 1.170.0 (#1659) New Crowdin translations (#1593) Shared: Copy missing strings (#1655) Desktop: Fix string Update desktop tests Mobile: Bump build no to 67 Mobile: Temporarily disable basic auth (#1651) Shared: Downgrade @iota/core to 1.0.0-beta.11 (#1649) fix: correctly call promote & reattach actions during manual promotion (#1648) Shared: Block autoretry if a tx has a fatal error on retry (#1644) Mobile: Bump build no to 66 ... # Conflicts: # src/desktop/package.json # src/desktop/src/index.js # src/desktop/src/ui/global/About.js
laumair
pushed a commit
that referenced
this pull request
Jun 7, 2019
* Remove random selection of node on app start up * Make quorumSize configurable quorumSize is currently used as a global constant throughout the quorum implementation. This is limiting especially for cases where we want quorumSize to be used as a user-defined variable. This commit updates the quorum implementation and accepts quorumSize as a configurable variable. * Mobile: Add basic node settings UI shell * feat: add nodes manager for handling network requests to IRI nodes * feat: add state variables & actions for quorum configuration * feat: add state variables & actions for node auto-switching * feat: update realm schema for authentication key * feat: update realm schema for quorum configuration * feat: add state variables & actions for node auto nost list * Mobile: Add mock node settings and update custom node UI * feat: do not retry on different nodes if auto node switching is disabled * feat: add wallet storage methods for new node improvements * Mobile: Update toggle styling * Mobile: Fix addCustomNode layout animation * Mobile: Update node settings * Mobile: Settings refactor * feat: minor updates - Replace deprecated #withRetriesOnDifferentNodes with NodesManager.withRetries - Change the way nodes data is stored in redux. Also update corresponding actions. - Allow caller of nodesConfigurationFactory to override nodes * Initial node granularity UI implementation * Fix linting errors * Mobile: Fix automatic node mangagement setting * feat: make sure all utils from extendedApi module accept provider settings as first parameter * feat: make sure all wallet actions are wrapped with NodeManager.withRetries * feat: Cancel auto-retry on (some) application generated errors * feat: Automatically retry on different nodes on failed transaction action * feat: add password property in nodes data * feat: make sure @iota/core methods are passed with username & password * feat: make sure promotion & reattachment actions are wrapped inside NodeManager.withRetries method * feat: make sure prepareTransfer method of SeedStore class accept node settings parameter * fix: update/fix failing tests * Update node granularity UI * Linting fixes * Mobile: Comment out redux logger * fix: make sure iota.settings object has provider property * Shared: Fix various issues with node settings * Shared: Minor custom node fixes * Shared: Fix incorrect node config * fix: do not mutate state.settings.quorum object * feat: use redux store directly in NodesManager class * Mobile: Fix node settings being updated incorrectly * Shared: Fix node change alerts * - Remove `autoNodeSelection` from props - Clear custom node input after adding custom node - Update custom node list to node object use * Mobile: Remove log statements * Add quorum size checks * Add `MAXIMUM_QUORUM_SIZE` * Change state node on prop change * Mobile: Add max quorum size and change node if updated from props * Mobile: Node settings comments and cleanup * Mobile: Adjust node settings comments * Mobile: Fix quorum size options and available nodes * Update Primary node to a Select * Remove deprecated `autoNodeSwitching` * Fix lint errors * Shared: Fix node lists and quorum size * Shared: Fix quorum config storage in realm * Shared: Fix setting of quorum size * Mobile: Clean up use of omit * Mobile: Fix node selection list * Mobile: Adjust quorum size update behaviour * Shared: Move all action types to a separate file (#1578) * chore: move action types to a separate file This commit moves all action types to a separate directory /types to avoid circular dependencies. * fix: update failing tests * Node selection improvement fixes (#1597) * Desktop: Lock node-usb to 1.5.0 (#1580) * Desktop: Use executable icon for application window BrowserWindow can default to executable icon if no icon is set, which works nicely on all platforms. * Check for correct Realm encryption key length (#1585) * New Crowdin translations (#1559) * New translations translation.json (German) * New translations translation.json (Swedish) * New translations translation.json (Norwegian) * Mobile: Fix and refactor PasswordFields (#1554) * Mobile: Fix long account name styling on transfer confirmation modal (#1569) * Mobile: Fix long account name styling on transfer confirmation modal * Update src/mobile/src/ui/components/TransferConfirmationModal.js * Mobile: Bump build numbers for release 0.7.1 (62) (#1586) * Bump snyk from 1.166.0 to 1.166.1 (#1587) * Bump @ledgerhq/hw-transport-node-hid from 4.58.0 to 4.60.0 in /src/desktop (#1589) * Bump @ledgerhq/hw-transport-node-hid in /src/desktop Bumps [@ledgerhq/hw-transport-node-hid](https://github.com/LedgerHQ/ledgerjs) from 4.58.0 to 4.60.0. - [Release notes](https://github.com/LedgerHQ/ledgerjs/releases) - [Commits](LedgerHQ/ledgerjs@v4.58.0...v4.60.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Desktop: Lock usb to 1.5.0 * Revert to usb `1.5.0` * fix realm schema version 3 migration issues * fix: resolve lint errors in desktop/ * fix failing tests (mobile & desktop) * chore: upgrade iota.lib.js to latest version * Shared: Add not enough synced nodes for quorum alert and refactor al… (#1577) * Shared: Add not enough synced nodes for quorum alert and refactor alerts * Shared: Rename alert * Mobile: Fix auth fields crash * fix: fallback to default node object if node list is empty * fix: update extendedApi tests * Shared: Fix v3 migration * Mobile: Bump build no to 63 * Mobile: Bump build number to 64 * Mobile: Bump build numbers for release v0.7.2 (65) * Mobile: Fix blank screen when changing node from loading * Mobile: Fix settings dual footer activityy indicator placement * Mobile: Clean up add custom node fields * Mobile: Allow exporting complete settings from state (#1637) * feat: expose quorum nodes & size * feat: update state props in state export This commit allows exporting `state.settings` & exposed values on global instances * Mobile: Bump build no to 66 * Shared: Block autoretry if a tx has a fatal error on retry (#1644) * feat: limit broadcast loop * Desktop: Link up autoretry limiting * Shared: Update autoretry attempts on manual retry and only update when tx error is fatal * Shared: Remove retry count and block autoretry on one fatal tx error * feat: assign "fatalErrorOnRetry" to transactions when account info is synced * fix: correctly call promote & reattach actions during manual promotion (#1648) * Shared: Downgrade @iota/core to 1.0.0-beta.11 (#1649) * Shared: Revert iota core version * Mobile: Update yarn.lock * Mobile: Temporarily disable basic auth (#1651) * Mobile: Bump build no to 67 * Update desktop tests * Desktop: Fix string * Temporary disable custom node authorisation entry * Update failing tests * Desktop linting fixes * Mobile: Fix crashes/behaviour on node settings * Shared: Fix remote node list and out of sync alerts (#1672) * Shared: Add missing strings * Shared: Fix fetch remote node list functionality * Shared: Adjust fetch remote node list behaviour * Shared: Fix out of sync alerts * Shared: Remove unnecessary dispatch * Shared: Remove unnecessary dispatch * Shared: Minor refactor * Update src/shared/locales/en/translation.json * Shared: If enabled only sample remote pow nodes for autoswitching (#1673) * Shared: If enabled only sample remote pow nodes for autoswitching * Shared: Add clonedeep to avoid mutation * Mobile: Bump build no to 68 * Update Custom node management functionality (#1691) * fix: remove undefined withAutoNodeSwitching HOC
rihardsgravis
pushed a commit
that referenced
this pull request
Jun 7, 2019
* Bump snyk from 1.170.0 to 1.171.1 (#1701) * Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/android (#1699) * Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/ios (#1700) * Bump enzyme-adapter-react-16 from 1.13.2 to 1.14.0 in /src/desktop (#1703) Bumps [enzyme-adapter-react-16](https://github.com/airbnb/enzyme/tree/HEAD/packages/enzyme-adapter-react-16) from 1.13.2 to 1.14.0. - [Release notes](https://github.com/airbnb/enzyme/releases) - [Changelog](https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/enzyme/commits/enzyme-adapter-react-16@1.14.0/packages/enzyme-adapter-react-16) * Bump enzyme from 3.9.0 to 3.10.0 in /src/desktop (#1697) Bumps [enzyme](https://github.com/airbnb/enzyme/tree/HEAD/packages/enzyme) from 3.9.0 to 3.10.0. - [Release notes](https://github.com/airbnb/enzyme/releases) - [Changelog](https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/enzyme/commits/enzyme@3.10.0/packages/enzyme) * Bump @ledgerhq/hw-transport-node-hid from 4.60.3 to 4.61.1 in /src/desktop (#1702) * Bump @ledgerhq/hw-transport-node-hid in /src/desktop Bumps [@ledgerhq/hw-transport-node-hid](https://github.com/LedgerHQ/ledgerjs) from 4.60.3 to 4.61.1. - [Release notes](https://github.com/LedgerHQ/ledgerjs/releases) - [Commits](LedgerHQ/ledgerjs@v4.60.3...v4.61.1) * Lock usb version to `1.5.0` * Bump i18next from 15.1.3 to 16.0.0 in /src/desktop (#1696) Bumps [i18next](https://github.com/i18next/i18next) from 15.1.3 to 16.0.0. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v15.1.3...v16.0.0) * Fix location reload on wallet reset (#1687) * Desktop: Auto update functionality updates (#1705) * - Show a localised error message for failing updates - Disable update header while update in progress * Linting fixes and and tests update * Revert temporary test version number * Remove `setImmediate` * Desktop: Update wallet language on initial load (#1704) * Update language on initial load * Update `i18next` and `react-i18next` dependencies * Update failing test snapshots * Bump i18next from 16.0.0 to 17.0.1 in /src/desktop (#1711) Bumps [i18next](https://github.com/i18next/i18next) from 16.0.0 to 17.0.1. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v16.0.0...v17.0.1) * Bump webpack from 4.32.2 to 4.33.0 in /src/desktop (#1709) Bumps [webpack](https://github.com/webpack/webpack) from 4.32.2 to 4.33.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.32.2...v4.33.0) * Bump react-router-dom from 5.0.0 to 5.0.1 in /src/desktop (#1710) Bumps [react-router-dom](https://github.com/ReactTraining/react-router) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/ReactTraining/react-router/releases) - [Commits](remix-run/react-router@v5.0.0...v5.0.1) * Bump electron-builder from 20.41.0 to 20.43.0 in /src/desktop (#1708) Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 20.41.0 to 20.43.0. - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/CHANGELOG.md) - [Commits](electron-userland/electron-builder@v20.41.0...v20.43.0) * Update action logic on full account info fetch error (#1688) * Bump snyk from 1.171.1 to 1.173.1 (#1716) * Bump husky from 2.3.0 to 2.4.0 (#1717) * New Crowdin translations (#1680) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Hindi) * New translations translation.json (Hindi) * New translations translation.json (German) * New translations translation.json (German) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (French) * New translations translation.json (French) * New translations translation.json (Chinese Simplified) * New translations translation.json (Urdu (Pakistan)) * New translations translation.json (Maori) * New translations translation.json (Vietnamese) * New translations translation.json (Turkish) * New translations translation.json (Arabic) * New translations translation.json (Georgian) * New translations translation.json (French) * New translations translation.json (Estonian) * New translations translation.json (Dutch) * New translations translation.json (Danish) * New translations translation.json (Croatian) * New translations translation.json (Chinese Traditional) * New translations translation.json (Bulgarian) * New translations translation.json (German, Switzerland) * New translations translation.json (Spanish, Latin America) * New translations translation.json (Spanish) * New translations translation.json (Romanian) * New translations translation.json (Polish) * New translations translation.json (Finnish) * New translations translation.json (Czech) * New translations translation.json (German) * New translations translation.json (Greek) * New translations translation.json (Thai) * New translations translation.json (Persian) * New translations translation.json (Tamil) * New translations translation.json (Swedish) * New translations translation.json (Slovenian) * New translations translation.json (Slovak) * New translations translation.json (Serbian (Latin)) * New translations translation.json (Russian) * New translations translation.json (Portuguese, Brazilian) * New translations translation.json (Portuguese) * New translations translation.json (Norwegian) * New translations translation.json (Hebrew) * New translations translation.json (Lithuanian) * New translations translation.json (Latvian) * New translations translation.json (Korean) * New translations translation.json (Kannada) * New translations translation.json (Japanese) * New translations translation.json (Italian) * New translations translation.json (Indonesian) * New translations translation.json (Hungarian) * New translations translation.json (Hindi) * New translations translation.json (Polish) * New translations translation.json (Japanese) * Bump @jest-runner/electron from 2.0.0 to 2.0.1 in /src/desktop (#1713) Bumps [@jest-runner/electron](https://github.com/facebook-atom/jest-electron-runner) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/facebook-atom/jest-electron-runner/releases) - [Commits](facebook-atom/jest-electron-runner@v2.0.0...v2.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump i18next from 17.0.1 to 17.0.2 in /src/desktop (#1722) Bumps [i18next](https://github.com/i18next/i18next) from 17.0.1 to 17.0.2. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v17.0.1...v17.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump file-loader from 3.0.1 to 4.0.0 in /src/desktop (#1715) Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 3.0.1 to 4.0.0. - [Release notes](https://github.com/webpack-contrib/file-loader/releases) - [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/file-loader@v3.0.1...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump url-loader from 1.1.2 to 2.0.0 in /src/desktop (#1714) Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 1.1.2 to 2.0.0. - [Release notes](https://github.com/webpack-contrib/url-loader/releases) - [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/url-loader@v1.1.2...v2.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump electron from 3.1.10 to 3.1.11 in /src/desktop (#1720) Bumps [electron](https://github.com/electron/electron) from 3.1.10 to 3.1.11. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v3.1.10...v3.1.11) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump dart-sass from 1.20.3 to 1.21.0 in /src/desktop (#1725) Bumps [dart-sass](https://github.com/sass/dart-sass) from 1.20.3 to 1.21.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](sass/dart-sass@1.20.3...1.21.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Shared: Node Settings Update (#1509) * Remove random selection of node on app start up * Make quorumSize configurable quorumSize is currently used as a global constant throughout the quorum implementation. This is limiting especially for cases where we want quorumSize to be used as a user-defined variable. This commit updates the quorum implementation and accepts quorumSize as a configurable variable. * Mobile: Add basic node settings UI shell * feat: add nodes manager for handling network requests to IRI nodes * feat: add state variables & actions for quorum configuration * feat: add state variables & actions for node auto-switching * feat: update realm schema for authentication key * feat: update realm schema for quorum configuration * feat: add state variables & actions for node auto nost list * Mobile: Add mock node settings and update custom node UI * feat: do not retry on different nodes if auto node switching is disabled * feat: add wallet storage methods for new node improvements * Mobile: Update toggle styling * Mobile: Fix addCustomNode layout animation * Mobile: Update node settings * Mobile: Settings refactor * feat: minor updates - Replace deprecated #withRetriesOnDifferentNodes with NodesManager.withRetries - Change the way nodes data is stored in redux. Also update corresponding actions. - Allow caller of nodesConfigurationFactory to override nodes * Initial node granularity UI implementation * Fix linting errors * Mobile: Fix automatic node mangagement setting * feat: make sure all utils from extendedApi module accept provider settings as first parameter * feat: make sure all wallet actions are wrapped with NodeManager.withRetries * feat: Cancel auto-retry on (some) application generated errors * feat: Automatically retry on different nodes on failed transaction action * feat: add password property in nodes data * feat: make sure @iota/core methods are passed with username & password * feat: make sure promotion & reattachment actions are wrapped inside NodeManager.withRetries method * feat: make sure prepareTransfer method of SeedStore class accept node settings parameter * fix: update/fix failing tests * Update node granularity UI * Linting fixes * Mobile: Comment out redux logger * fix: make sure iota.settings object has provider property * Shared: Fix various issues with node settings * Shared: Minor custom node fixes * Shared: Fix incorrect node config * fix: do not mutate state.settings.quorum object * feat: use redux store directly in NodesManager class * Mobile: Fix node settings being updated incorrectly * Shared: Fix node change alerts * - Remove `autoNodeSelection` from props - Clear custom node input after adding custom node - Update custom node list to node object use * Mobile: Remove log statements * Add quorum size checks * Add `MAXIMUM_QUORUM_SIZE` * Change state node on prop change * Mobile: Add max quorum size and change node if updated from props * Mobile: Node settings comments and cleanup * Mobile: Adjust node settings comments * Mobile: Fix quorum size options and available nodes * Update Primary node to a Select * Remove deprecated `autoNodeSwitching` * Fix lint errors * Shared: Fix node lists and quorum size * Shared: Fix quorum config storage in realm * Shared: Fix setting of quorum size * Mobile: Clean up use of omit * Mobile: Fix node selection list * Mobile: Adjust quorum size update behaviour * Shared: Move all action types to a separate file (#1578) * chore: move action types to a separate file This commit moves all action types to a separate directory /types to avoid circular dependencies. * fix: update failing tests * Node selection improvement fixes (#1597) * Desktop: Lock node-usb to 1.5.0 (#1580) * Desktop: Use executable icon for application window BrowserWindow can default to executable icon if no icon is set, which works nicely on all platforms. * Check for correct Realm encryption key length (#1585) * New Crowdin translations (#1559) * New translations translation.json (German) * New translations translation.json (Swedish) * New translations translation.json (Norwegian) * Mobile: Fix and refactor PasswordFields (#1554) * Mobile: Fix long account name styling on transfer confirmation modal (#1569) * Mobile: Fix long account name styling on transfer confirmation modal * Update src/mobile/src/ui/components/TransferConfirmationModal.js * Mobile: Bump build numbers for release 0.7.1 (62) (#1586) * Bump snyk from 1.166.0 to 1.166.1 (#1587) * Bump @ledgerhq/hw-transport-node-hid from 4.58.0 to 4.60.0 in /src/desktop (#1589) * Bump @ledgerhq/hw-transport-node-hid in /src/desktop Bumps [@ledgerhq/hw-transport-node-hid](https://github.com/LedgerHQ/ledgerjs) from 4.58.0 to 4.60.0. - [Release notes](https://github.com/LedgerHQ/ledgerjs/releases) - [Commits](LedgerHQ/ledgerjs@v4.58.0...v4.60.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Desktop: Lock usb to 1.5.0 * Revert to usb `1.5.0` * fix realm schema version 3 migration issues * fix: resolve lint errors in desktop/ * fix failing tests (mobile & desktop) * chore: upgrade iota.lib.js to latest version * Shared: Add not enough synced nodes for quorum alert and refactor al… (#1577) * Shared: Add not enough synced nodes for quorum alert and refactor alerts * Shared: Rename alert * Mobile: Fix auth fields crash * fix: fallback to default node object if node list is empty * fix: update extendedApi tests * Shared: Fix v3 migration * Mobile: Bump build no to 63 * Mobile: Bump build number to 64 * Mobile: Bump build numbers for release v0.7.2 (65) * Mobile: Fix blank screen when changing node from loading * Mobile: Fix settings dual footer activityy indicator placement * Mobile: Clean up add custom node fields * Mobile: Allow exporting complete settings from state (#1637) * feat: expose quorum nodes & size * feat: update state props in state export This commit allows exporting `state.settings` & exposed values on global instances * Mobile: Bump build no to 66 * Shared: Block autoretry if a tx has a fatal error on retry (#1644) * feat: limit broadcast loop * Desktop: Link up autoretry limiting * Shared: Update autoretry attempts on manual retry and only update when tx error is fatal * Shared: Remove retry count and block autoretry on one fatal tx error * feat: assign "fatalErrorOnRetry" to transactions when account info is synced * fix: correctly call promote & reattach actions during manual promotion (#1648) * Shared: Downgrade @iota/core to 1.0.0-beta.11 (#1649) * Shared: Revert iota core version * Mobile: Update yarn.lock * Mobile: Temporarily disable basic auth (#1651) * Mobile: Bump build no to 67 * Update desktop tests * Desktop: Fix string * Temporary disable custom node authorisation entry * Update failing tests * Desktop linting fixes * Mobile: Fix crashes/behaviour on node settings * Shared: Fix remote node list and out of sync alerts (#1672) * Shared: Add missing strings * Shared: Fix fetch remote node list functionality * Shared: Adjust fetch remote node list behaviour * Shared: Fix out of sync alerts * Shared: Remove unnecessary dispatch * Shared: Remove unnecessary dispatch * Shared: Minor refactor * Update src/shared/locales/en/translation.json * Shared: If enabled only sample remote pow nodes for autoswitching (#1673) * Shared: If enabled only sample remote pow nodes for autoswitching * Shared: Add clonedeep to avoid mutation * Mobile: Bump build no to 68 * Update Custom node management functionality (#1691) * fix: remove undefined withAutoNodeSwitching HOC * feat: update realm schema to incorporate settings.ignoreSettings addition
rihardsgravis
added a commit
that referenced
this pull request
Jun 7, 2019
* Add `ignoreProxy` setting to Realm * ignoreProxy realm changes (#1730) * Bump snyk from 1.170.0 to 1.171.1 (#1701) * Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/android (#1699) * Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/ios (#1700) * Bump enzyme-adapter-react-16 from 1.13.2 to 1.14.0 in /src/desktop (#1703) Bumps [enzyme-adapter-react-16](https://github.com/airbnb/enzyme/tree/HEAD/packages/enzyme-adapter-react-16) from 1.13.2 to 1.14.0. - [Release notes](https://github.com/airbnb/enzyme/releases) - [Changelog](https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/enzyme/commits/enzyme-adapter-react-16@1.14.0/packages/enzyme-adapter-react-16) * Bump enzyme from 3.9.0 to 3.10.0 in /src/desktop (#1697) Bumps [enzyme](https://github.com/airbnb/enzyme/tree/HEAD/packages/enzyme) from 3.9.0 to 3.10.0. - [Release notes](https://github.com/airbnb/enzyme/releases) - [Changelog](https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/enzyme/commits/enzyme@3.10.0/packages/enzyme) * Bump @ledgerhq/hw-transport-node-hid from 4.60.3 to 4.61.1 in /src/desktop (#1702) * Bump @ledgerhq/hw-transport-node-hid in /src/desktop Bumps [@ledgerhq/hw-transport-node-hid](https://github.com/LedgerHQ/ledgerjs) from 4.60.3 to 4.61.1. - [Release notes](https://github.com/LedgerHQ/ledgerjs/releases) - [Commits](LedgerHQ/ledgerjs@v4.60.3...v4.61.1) * Lock usb version to `1.5.0` * Bump i18next from 15.1.3 to 16.0.0 in /src/desktop (#1696) Bumps [i18next](https://github.com/i18next/i18next) from 15.1.3 to 16.0.0. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v15.1.3...v16.0.0) * Fix location reload on wallet reset (#1687) * Desktop: Auto update functionality updates (#1705) * - Show a localised error message for failing updates - Disable update header while update in progress * Linting fixes and and tests update * Revert temporary test version number * Remove `setImmediate` * Desktop: Update wallet language on initial load (#1704) * Update language on initial load * Update `i18next` and `react-i18next` dependencies * Update failing test snapshots * Bump i18next from 16.0.0 to 17.0.1 in /src/desktop (#1711) Bumps [i18next](https://github.com/i18next/i18next) from 16.0.0 to 17.0.1. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v16.0.0...v17.0.1) * Bump webpack from 4.32.2 to 4.33.0 in /src/desktop (#1709) Bumps [webpack](https://github.com/webpack/webpack) from 4.32.2 to 4.33.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.32.2...v4.33.0) * Bump react-router-dom from 5.0.0 to 5.0.1 in /src/desktop (#1710) Bumps [react-router-dom](https://github.com/ReactTraining/react-router) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/ReactTraining/react-router/releases) - [Commits](remix-run/react-router@v5.0.0...v5.0.1) * Bump electron-builder from 20.41.0 to 20.43.0 in /src/desktop (#1708) Bumps [electron-builder](https://github.com/electron-userland/electron-builder) from 20.41.0 to 20.43.0. - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/CHANGELOG.md) - [Commits](electron-userland/electron-builder@v20.41.0...v20.43.0) * Update action logic on full account info fetch error (#1688) * Bump snyk from 1.171.1 to 1.173.1 (#1716) * Bump husky from 2.3.0 to 2.4.0 (#1717) * New Crowdin translations (#1680) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Norwegian) * New translations translation.json (Hindi) * New translations translation.json (Hindi) * New translations translation.json (German) * New translations translation.json (German) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (Czech) * New translations translation.json (French) * New translations translation.json (French) * New translations translation.json (French) * New translations translation.json (Chinese Simplified) * New translations translation.json (Urdu (Pakistan)) * New translations translation.json (Maori) * New translations translation.json (Vietnamese) * New translations translation.json (Turkish) * New translations translation.json (Arabic) * New translations translation.json (Georgian) * New translations translation.json (French) * New translations translation.json (Estonian) * New translations translation.json (Dutch) * New translations translation.json (Danish) * New translations translation.json (Croatian) * New translations translation.json (Chinese Traditional) * New translations translation.json (Bulgarian) * New translations translation.json (German, Switzerland) * New translations translation.json (Spanish, Latin America) * New translations translation.json (Spanish) * New translations translation.json (Romanian) * New translations translation.json (Polish) * New translations translation.json (Finnish) * New translations translation.json (Czech) * New translations translation.json (German) * New translations translation.json (Greek) * New translations translation.json (Thai) * New translations translation.json (Persian) * New translations translation.json (Tamil) * New translations translation.json (Swedish) * New translations translation.json (Slovenian) * New translations translation.json (Slovak) * New translations translation.json (Serbian (Latin)) * New translations translation.json (Russian) * New translations translation.json (Portuguese, Brazilian) * New translations translation.json (Portuguese) * New translations translation.json (Norwegian) * New translations translation.json (Hebrew) * New translations translation.json (Lithuanian) * New translations translation.json (Latvian) * New translations translation.json (Korean) * New translations translation.json (Kannada) * New translations translation.json (Japanese) * New translations translation.json (Italian) * New translations translation.json (Indonesian) * New translations translation.json (Hungarian) * New translations translation.json (Hindi) * New translations translation.json (Polish) * New translations translation.json (Japanese) * Bump @jest-runner/electron from 2.0.0 to 2.0.1 in /src/desktop (#1713) Bumps [@jest-runner/electron](https://github.com/facebook-atom/jest-electron-runner) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/facebook-atom/jest-electron-runner/releases) - [Commits](facebook-atom/jest-electron-runner@v2.0.0...v2.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump i18next from 17.0.1 to 17.0.2 in /src/desktop (#1722) Bumps [i18next](https://github.com/i18next/i18next) from 17.0.1 to 17.0.2. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v17.0.1...v17.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump file-loader from 3.0.1 to 4.0.0 in /src/desktop (#1715) Bumps [file-loader](https://github.com/webpack-contrib/file-loader) from 3.0.1 to 4.0.0. - [Release notes](https://github.com/webpack-contrib/file-loader/releases) - [Changelog](https://github.com/webpack-contrib/file-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/file-loader@v3.0.1...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump url-loader from 1.1.2 to 2.0.0 in /src/desktop (#1714) Bumps [url-loader](https://github.com/webpack-contrib/url-loader) from 1.1.2 to 2.0.0. - [Release notes](https://github.com/webpack-contrib/url-loader/releases) - [Changelog](https://github.com/webpack-contrib/url-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/url-loader@v1.1.2...v2.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump electron from 3.1.10 to 3.1.11 in /src/desktop (#1720) Bumps [electron](https://github.com/electron/electron) from 3.1.10 to 3.1.11. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v3.1.10...v3.1.11) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump dart-sass from 1.20.3 to 1.21.0 in /src/desktop (#1725) Bumps [dart-sass](https://github.com/sass/dart-sass) from 1.20.3 to 1.21.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](sass/dart-sass@1.20.3...1.21.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Shared: Node Settings Update (#1509) * Remove random selection of node on app start up * Make quorumSize configurable quorumSize is currently used as a global constant throughout the quorum implementation. This is limiting especially for cases where we want quorumSize to be used as a user-defined variable. This commit updates the quorum implementation and accepts quorumSize as a configurable variable. * Mobile: Add basic node settings UI shell * feat: add nodes manager for handling network requests to IRI nodes * feat: add state variables & actions for quorum configuration * feat: add state variables & actions for node auto-switching * feat: update realm schema for authentication key * feat: update realm schema for quorum configuration * feat: add state variables & actions for node auto nost list * Mobile: Add mock node settings and update custom node UI * feat: do not retry on different nodes if auto node switching is disabled * feat: add wallet storage methods for new node improvements * Mobile: Update toggle styling * Mobile: Fix addCustomNode layout animation * Mobile: Update node settings * Mobile: Settings refactor * feat: minor updates - Replace deprecated #withRetriesOnDifferentNodes with NodesManager.withRetries - Change the way nodes data is stored in redux. Also update corresponding actions. - Allow caller of nodesConfigurationFactory to override nodes * Initial node granularity UI implementation * Fix linting errors * Mobile: Fix automatic node mangagement setting * feat: make sure all utils from extendedApi module accept provider settings as first parameter * feat: make sure all wallet actions are wrapped with NodeManager.withRetries * feat: Cancel auto-retry on (some) application generated errors * feat: Automatically retry on different nodes on failed transaction action * feat: add password property in nodes data * feat: make sure @iota/core methods are passed with username & password * feat: make sure promotion & reattachment actions are wrapped inside NodeManager.withRetries method * feat: make sure prepareTransfer method of SeedStore class accept node settings parameter * fix: update/fix failing tests * Update node granularity UI * Linting fixes * Mobile: Comment out redux logger * fix: make sure iota.settings object has provider property * Shared: Fix various issues with node settings * Shared: Minor custom node fixes * Shared: Fix incorrect node config * fix: do not mutate state.settings.quorum object * feat: use redux store directly in NodesManager class * Mobile: Fix node settings being updated incorrectly * Shared: Fix node change alerts * - Remove `autoNodeSelection` from props - Clear custom node input after adding custom node - Update custom node list to node object use * Mobile: Remove log statements * Add quorum size checks * Add `MAXIMUM_QUORUM_SIZE` * Change state node on prop change * Mobile: Add max quorum size and change node if updated from props * Mobile: Node settings comments and cleanup * Mobile: Adjust node settings comments * Mobile: Fix quorum size options and available nodes * Update Primary node to a Select * Remove deprecated `autoNodeSwitching` * Fix lint errors * Shared: Fix node lists and quorum size * Shared: Fix quorum config storage in realm * Shared: Fix setting of quorum size * Mobile: Clean up use of omit * Mobile: Fix node selection list * Mobile: Adjust quorum size update behaviour * Shared: Move all action types to a separate file (#1578) * chore: move action types to a separate file This commit moves all action types to a separate directory /types to avoid circular dependencies. * fix: update failing tests * Node selection improvement fixes (#1597) * Desktop: Lock node-usb to 1.5.0 (#1580) * Desktop: Use executable icon for application window BrowserWindow can default to executable icon if no icon is set, which works nicely on all platforms. * Check for correct Realm encryption key length (#1585) * New Crowdin translations (#1559) * New translations translation.json (German) * New translations translation.json (Swedish) * New translations translation.json (Norwegian) * Mobile: Fix and refactor PasswordFields (#1554) * Mobile: Fix long account name styling on transfer confirmation modal (#1569) * Mobile: Fix long account name styling on transfer confirmation modal * Update src/mobile/src/ui/components/TransferConfirmationModal.js * Mobile: Bump build numbers for release 0.7.1 (62) (#1586) * Bump snyk from 1.166.0 to 1.166.1 (#1587) * Bump @ledgerhq/hw-transport-node-hid from 4.58.0 to 4.60.0 in /src/desktop (#1589) * Bump @ledgerhq/hw-transport-node-hid in /src/desktop Bumps [@ledgerhq/hw-transport-node-hid](https://github.com/LedgerHQ/ledgerjs) from 4.58.0 to 4.60.0. - [Release notes](https://github.com/LedgerHQ/ledgerjs/releases) - [Commits](LedgerHQ/ledgerjs@v4.58.0...v4.60.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Desktop: Lock usb to 1.5.0 * Revert to usb `1.5.0` * fix realm schema version 3 migration issues * fix: resolve lint errors in desktop/ * fix failing tests (mobile & desktop) * chore: upgrade iota.lib.js to latest version * Shared: Add not enough synced nodes for quorum alert and refactor al… (#1577) * Shared: Add not enough synced nodes for quorum alert and refactor alerts * Shared: Rename alert * Mobile: Fix auth fields crash * fix: fallback to default node object if node list is empty * fix: update extendedApi tests * Shared: Fix v3 migration * Mobile: Bump build no to 63 * Mobile: Bump build number to 64 * Mobile: Bump build numbers for release v0.7.2 (65) * Mobile: Fix blank screen when changing node from loading * Mobile: Fix settings dual footer activityy indicator placement * Mobile: Clean up add custom node fields * Mobile: Allow exporting complete settings from state (#1637) * feat: expose quorum nodes & size * feat: update state props in state export This commit allows exporting `state.settings` & exposed values on global instances * Mobile: Bump build no to 66 * Shared: Block autoretry if a tx has a fatal error on retry (#1644) * feat: limit broadcast loop * Desktop: Link up autoretry limiting * Shared: Update autoretry attempts on manual retry and only update when tx error is fatal * Shared: Remove retry count and block autoretry on one fatal tx error * feat: assign "fatalErrorOnRetry" to transactions when account info is synced * fix: correctly call promote & reattach actions during manual promotion (#1648) * Shared: Downgrade @iota/core to 1.0.0-beta.11 (#1649) * Shared: Revert iota core version * Mobile: Update yarn.lock * Mobile: Temporarily disable basic auth (#1651) * Mobile: Bump build no to 67 * Update desktop tests * Desktop: Fix string * Temporary disable custom node authorisation entry * Update failing tests * Desktop linting fixes * Mobile: Fix crashes/behaviour on node settings * Shared: Fix remote node list and out of sync alerts (#1672) * Shared: Add missing strings * Shared: Fix fetch remote node list functionality * Shared: Adjust fetch remote node list behaviour * Shared: Fix out of sync alerts * Shared: Remove unnecessary dispatch * Shared: Remove unnecessary dispatch * Shared: Minor refactor * Update src/shared/locales/en/translation.json * Shared: If enabled only sample remote pow nodes for autoswitching (#1673) * Shared: If enabled only sample remote pow nodes for autoswitching * Shared: Add clonedeep to avoid mutation * Mobile: Bump build no to 68 * Update Custom node management functionality (#1691) * fix: remove undefined withAutoNodeSwitching HOC * feat: update realm schema to incorporate settings.ignoreSettings addition * Merge fix
cvarley100
pushed a commit
that referenced
this pull request
Jun 14, 2019
* Remove random selection of node on app start up * Make quorumSize configurable quorumSize is currently used as a global constant throughout the quorum implementation. This is limiting especially for cases where we want quorumSize to be used as a user-defined variable. This commit updates the quorum implementation and accepts quorumSize as a configurable variable. * Mobile: Add basic node settings UI shell * feat: add nodes manager for handling network requests to IRI nodes * feat: add state variables & actions for quorum configuration * feat: add state variables & actions for node auto-switching * feat: update realm schema for authentication key * feat: update realm schema for quorum configuration * feat: add state variables & actions for node auto nost list * Mobile: Add mock node settings and update custom node UI * feat: do not retry on different nodes if auto node switching is disabled * feat: add wallet storage methods for new node improvements * Mobile: Update toggle styling * Mobile: Fix addCustomNode layout animation * Mobile: Update node settings * Mobile: Settings refactor * feat: minor updates - Replace deprecated #withRetriesOnDifferentNodes with NodesManager.withRetries - Change the way nodes data is stored in redux. Also update corresponding actions. - Allow caller of nodesConfigurationFactory to override nodes * Initial node granularity UI implementation * Fix linting errors * Mobile: Fix automatic node mangagement setting * feat: make sure all utils from extendedApi module accept provider settings as first parameter * feat: make sure all wallet actions are wrapped with NodeManager.withRetries * feat: Cancel auto-retry on (some) application generated errors * feat: Automatically retry on different nodes on failed transaction action * feat: add password property in nodes data * feat: make sure @iota/core methods are passed with username & password * feat: make sure promotion & reattachment actions are wrapped inside NodeManager.withRetries method * feat: make sure prepareTransfer method of SeedStore class accept node settings parameter * fix: update/fix failing tests * Update node granularity UI * Linting fixes * Mobile: Comment out redux logger * fix: make sure iota.settings object has provider property * Shared: Fix various issues with node settings * Shared: Minor custom node fixes * Shared: Fix incorrect node config * fix: do not mutate state.settings.quorum object * feat: use redux store directly in NodesManager class * Mobile: Fix node settings being updated incorrectly * Shared: Fix node change alerts * - Remove `autoNodeSelection` from props - Clear custom node input after adding custom node - Update custom node list to node object use * Mobile: Remove log statements * Add quorum size checks * Add `MAXIMUM_QUORUM_SIZE` * Change state node on prop change * Mobile: Add max quorum size and change node if updated from props * Mobile: Node settings comments and cleanup * Mobile: Adjust node settings comments * Mobile: Fix quorum size options and available nodes * Update Primary node to a Select * Remove deprecated `autoNodeSwitching` * Fix lint errors * Shared: Fix node lists and quorum size * Shared: Fix quorum config storage in realm * Shared: Fix setting of quorum size * Mobile: Clean up use of omit * Mobile: Fix node selection list * Mobile: Adjust quorum size update behaviour * Shared: Move all action types to a separate file (#1578) * chore: move action types to a separate file This commit moves all action types to a separate directory /types to avoid circular dependencies. * fix: update failing tests * Node selection improvement fixes (#1597) * Desktop: Lock node-usb to 1.5.0 (#1580) * Desktop: Use executable icon for application window BrowserWindow can default to executable icon if no icon is set, which works nicely on all platforms. * Check for correct Realm encryption key length (#1585) * New Crowdin translations (#1559) * New translations translation.json (German) * New translations translation.json (Swedish) * New translations translation.json (Norwegian) * Mobile: Fix and refactor PasswordFields (#1554) * Mobile: Fix long account name styling on transfer confirmation modal (#1569) * Mobile: Fix long account name styling on transfer confirmation modal * Update src/mobile/src/ui/components/TransferConfirmationModal.js * Mobile: Bump build numbers for release 0.7.1 (62) (#1586) * Bump snyk from 1.166.0 to 1.166.1 (#1587) * Bump @ledgerhq/hw-transport-node-hid from 4.58.0 to 4.60.0 in /src/desktop (#1589) * Bump @ledgerhq/hw-transport-node-hid in /src/desktop Bumps [@ledgerhq/hw-transport-node-hid](https://github.com/LedgerHQ/ledgerjs) from 4.58.0 to 4.60.0. - [Release notes](https://github.com/LedgerHQ/ledgerjs/releases) - [Commits](LedgerHQ/ledgerjs@v4.58.0...v4.60.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Desktop: Lock usb to 1.5.0 * Revert to usb `1.5.0` * fix realm schema version 3 migration issues * fix: resolve lint errors in desktop/ * fix failing tests (mobile & desktop) * chore: upgrade iota.lib.js to latest version * Shared: Add not enough synced nodes for quorum alert and refactor al… (#1577) * Shared: Add not enough synced nodes for quorum alert and refactor alerts * Shared: Rename alert * Mobile: Fix auth fields crash * fix: fallback to default node object if node list is empty * fix: update extendedApi tests * Shared: Fix v3 migration * Mobile: Bump build no to 63 * Mobile: Bump build number to 64 * Mobile: Bump build numbers for release v0.7.2 (65) * Mobile: Fix blank screen when changing node from loading * Mobile: Fix settings dual footer activityy indicator placement * Mobile: Clean up add custom node fields * Mobile: Allow exporting complete settings from state (#1637) * feat: expose quorum nodes & size * feat: update state props in state export This commit allows exporting `state.settings` & exposed values on global instances * Mobile: Bump build no to 66 * Shared: Block autoretry if a tx has a fatal error on retry (#1644) * feat: limit broadcast loop * Desktop: Link up autoretry limiting * Shared: Update autoretry attempts on manual retry and only update when tx error is fatal * Shared: Remove retry count and block autoretry on one fatal tx error * feat: assign "fatalErrorOnRetry" to transactions when account info is synced * fix: correctly call promote & reattach actions during manual promotion (#1648) * Shared: Downgrade @iota/core to 1.0.0-beta.11 (#1649) * Shared: Revert iota core version * Mobile: Update yarn.lock * Mobile: Temporarily disable basic auth (#1651) * Mobile: Bump build no to 67 * Update desktop tests * Desktop: Fix string * Temporary disable custom node authorisation entry * Update failing tests * Bump version and update Changelog to `0.6.0-RC1` * Desktop linting fixes * Mobile: Fix crashes/behaviour on node settings * Shared: Fix remote node list and out of sync alerts (#1672) * Shared: Add missing strings * Shared: Fix fetch remote node list functionality * Shared: Adjust fetch remote node list behaviour * Shared: Fix out of sync alerts * Shared: Remove unnecessary dispatch * Shared: Remove unnecessary dispatch * Shared: Minor refactor * Update src/shared/locales/en/translation.json * Version bump and Changelog update * Changelog update * Version bump and Changelog update * Version bump and Sidebar fix * Remove deprecated option * Linting fixes * Desktop: Prepare 0.6.0 release * Desktop: Update changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where function is displayed instead of tx hash while opening modals when promoting
Type of change
How Has This Been Tested?
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodesshared: If applicable, I have verified that my changes are implemented correctly indesktopandmobile