This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
feature(desktop): Reenable auto-updater on Windows and enable logging #2650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background
The auto-updater was previously disabled on Windows because a vulnerability in
electron-updater
allowed code signature verification to be bypassed. This vulnerability was found and disclosed by Luca Carettoni and Lorenzo Stella of Doyensec. While a fix was released by the maintainers ofelectron-updater
, it does not fully mitigate the issue (see electron-userland/electron-builder#4701).This PR prevents the bypass by aborting the update if code signature verification fails.
Type of change
How Has This Been Tested?
Checklist: