-
Notifications
You must be signed in to change notification settings - Fork 120
Desktop: Add network proxy ignore setting #648
Conversation
Would this PR solve #503? |
No. This change allows to ignore system wide proxy settings. That issue requests for manual proxy input. |
Ah, I see. I was under the impression that this would allow it to detect the system's proxy settings. I might be able to try that in a future PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Electron detects system proxy settings by default. A fix for #503 could be manual proxy input at Trinity Advanced settings. |
Description
Add system wide network proxy setting bypass setting.
Type of change
How Has This Been Tested?
Tested manually on macOS
Checklist:
shared
: If applicable, I have verified that my changes are implemented correctly indesktop
andmobile