Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Reset node list on state migration #810

Merged
merged 4 commits into from
Dec 16, 2018
Merged

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Dec 16, 2018

Description

Resets node list during state migration if the previous build number was less than 32 (mobile) or the current version is 0.4.5 (desktop). This will ensure that any RC nodes already in the state are removed.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested on iPhone 6S simulator

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@rajivshah3 rajivshah3 added T - Enhancement New feature or request C - Mobile C - Shared E - Functional Epic - Relating to how a feature works L - WIP Lifecycle - Work in Progress labels Dec 16, 2018
- Detect if a migration is needed on version upgrades
- Reset node list if version upgrade is to desktop version 0.4.5
- Persist desktop app version in store
@rajivshah3 rajivshah3 removed the L - WIP Lifecycle - Work in Progress label Dec 16, 2018
@rajivshah3 rajivshah3 changed the title WIP: Reset node list on state migration Reset node list on state migration Dec 16, 2018
@rajivshah3 rajivshah3 merged commit 3809e3a into develop Dec 16, 2018
@rajivshah3 rajivshah3 deleted the feature/node-list-reset branch December 16, 2018 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Mobile C - Shared E - Functional Epic - Relating to how a feature works T - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants