Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Shared: Fix selector for account names with special characters #896

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

rihardsgravis
Copy link
Contributor

@rihardsgravis rihardsgravis commented Jan 8, 2019

Description

Selector get(state.accountInfo, '${payload.accountName}.index') for account names containing special characters that match a valid path e.g. Foo [bar] resolve as undefined.
The selector path should be defined as an array of each path level defined separately.

Fixes #675

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rihardsgravis rihardsgravis added T - Bug Type - Bug: Something isn't working C - Shared P2 - High Priority - Prefer to fix or merge this labels Jan 8, 2019
@rihardsgravis rihardsgravis self-assigned this Jan 8, 2019
@rihardsgravis rihardsgravis changed the title Shared: Fix properties selector for account names with special characters Shared: Fix selector for account names with special characters Jan 8, 2019
@rihardsgravis rihardsgravis added the L - Need reviews Lifecycle - Each PR must have at least two reviewers label Jan 8, 2019
Copy link
Contributor

@laumair laumair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thank you.

@rajivshah3 rajivshah3 merged commit 7f2586a into develop Jan 8, 2019
@rajivshah3 rajivshah3 deleted the fix/special-character-account-names-selector branch January 8, 2019 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Shared L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this T - Bug Type - Bug: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ledger] Account gets broken after receiving/sending
3 participants