Bindings: reuse methods + consistency #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
changed the title
Thoralf-M
reviewed
Dec 14, 2022
Thoralf-M
reviewed
Dec 14, 2022
Thoralf-M
reviewed
Dec 14, 2022
Thoralf-M
reviewed
Dec 14, 2022
Thoralf-M
previously approved these changes
Dec 15, 2022
thibault-martinez
requested changes
Jan 12, 2023
Thoralf-M
previously approved these changes
Jan 13, 2023
added 2 commits
January 13, 2023 15:44
thibault-martinez
approved these changes
Jan 13, 2023
samuel-rufi
approved these changes
Jan 13, 2023
This was referenced Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates bindings code to reuse methods inside the rust crate message interface.
Updated bindings to use
send_messagewhen possible.Fixes #1611 #1619