LocalView redesigned, logging improvements, cleanup of consensus instances. #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kape1395
changed the title
muXxer
reviewed
Feb 20, 2023
| if len(entries) != 1 { | ||
| return nil // Alternatives exist. | ||
| } | ||
| if entries[0].rejected { |
There was a problem hiding this comment.
Do we need to loop over all entries here just to be safe that none of them is rejected? Or is this already clear if we only check the first entry?
There was a problem hiding this comment.
The check above tests if there is only a single element in the entries list. So it is enough here to check that single element.
There was a problem hiding this comment.
hahaha true :D sorry my bad.
Co-authored-by: muXxer <git@muxxer.de>
muXxer
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.