Add websockets v2 #1978
Merged
Add websockets v2 #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
reviewed
Feb 20, 2023
muXxer
reviewed
Feb 20, 2023
| default: | ||
| p.log.Warnf("dropping websocket message for %s", r.RemoteAddr) | ||
| if err := client.Send(ctx, event); err != nil { | ||
| p.log.Warnf("error sending message: %v", err) |
There was a problem hiding this comment.
maybe add the info to which client ID the send failed.
|
|
||
| var command SubscriptionCommand | ||
| if err := json.Unmarshal(message, &command); err != nil { | ||
| p.log.Warnf("Could not deserialize message to type ControlCommand, msg: '%v'", message) |
There was a problem hiding this comment.
you will print a byte slice here as a log message. better encode it to hex before.
There was a problem hiding this comment.
And add the info about the client.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds a new websocket to the webapi.
To be found on
ws://api.wasphost/wsSupports subscribing to message topics
Supports subscribing to chains (either all, or selected)
Links to any relevant issues
fixes issue #1414