refactor StateManger/StateReader #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
=========================================
- Coverage 61.37% 61.3% -0.07%
=========================================
Files 161 161
Lines 13300 13321 +21
=========================================
+ Hits 8163 8167 +4
- Misses 4099 4113 +14
- Partials 1038 1041 +3
Continue to review full report at Codecov.
|
CoderZhi
approved these changes
Feb 13, 2020
Comment on lines
+41
to
+48
| _, err = sm.State(&account, protocol.LegacyKeyOption(addrHash)) | ||
| if err == nil { | ||
| return &account, nil | ||
| } | ||
| if errors.Cause(err) == state.ErrStateNotExist { | ||
| account.Balance = big.NewInt(0) | ||
| account.VotingWeight = big.NewInt(0) | ||
| if err := sm.PutState(addrHash, account); err != nil { | ||
| if _, err := sm.PutState(account, protocol.LegacyKeyOption(addrHash)); err != nil { |
There was a problem hiding this comment.
this is the perfect place for us to check the versions (heights)
| @@ -126,9 +125,9 @@ func TestActQueuePendingActs(t *testing.T) { | |||
| require := require.New(t) | |||
| cfg := config.Default | |||
| sf := mock_factory.NewMockFactory(ctrl) | |||
| sf.EXPECT().State(gomock.Any(), gomock.Any()).Do(func(_ hash.Hash160, accountState *state.Account) { | |||
| sf.EXPECT().State(gomock.Any(), gomock.Any()).Do(func(accountState *state.Account, _ protocol.StateOption) { | |||
There was a problem hiding this comment.
is it
sf.EXPECT().State(gomock.Any(), gomock.Any()).Do(func(accountState *state.Account, _ ...protocol.StateOption) {
blockchain/blockchain.go
Outdated
| @@ -601,6 +601,7 @@ func (bc *blockchain) commitBlock(ctx context.Context, blk *block.Block) error { | |||
| sfTimer.End() | |||
| // detach working set so it can be freed by GC | |||
| if err != nil { | |||
| // | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works on #1882