-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staking] make contract staking indexer nullable #3883
[staking] make contract staking indexer nullable #3883
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3883 +/- ##
==========================================
+ Coverage 75.38% 75.61% +0.23%
==========================================
Files 303 326 +23
Lines 25923 27802 +1879
==========================================
+ Hits 19541 21023 +1482
- Misses 5360 5694 +334
- Partials 1022 1085 +63
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8adeee9
to
66806cf
Compare
4b1ded7
to
f7633fd
Compare
f7633fd
to
bf485f5
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
To improve flexibility and testability, make the contract staking indexer param in
staking.NewProtocol()
nullable.Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: