Add timeout package to attempt remedy of hanging bled112 test #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrunchey
force-pushed
the
fix-hanging-tests
branch
12 times, most recently
from
adc2c47
to
c9f75f2
Compare
Attempt a fix in the bled112 code to handle already being disconnected
mattrunchey
force-pushed
the
fix-hanging-tests
branch
from
c9f75f2
to
b0b5251
Compare
|
@mattrunchey. Given that we're refactoring this code, can we close this PR? |
|
Yea. I never could get a bead on what exactly caused the hang. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft just to get the tests to run.