Import bnsapi #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepuchyr
reviewed
Feb 5, 2020
.travis.yml
Outdated
| @@ -60,7 +61,6 @@ script: | |||
| - unset TRAVIS_COMMIT_MESSAGE && printenv | grep -Ev "PATH|path|GEM" > env.list | |||
| - export TRAVIS_COMMIT_MESSAGE=`cat commit.msg` && rm -rf commit.msg | |||
| - docker run -it --rm --env-file env.list -v "$(pwd):/usr/src/app" iov1ops/danger:latest > danger.out; cat danger.out | |||
| - make docker | |||
There was a problem hiding this comment.
Why drop docker? We will need a docker image for bnsapi.
davepuchyr
reviewed
Feb 5, 2020
Makefile
Outdated
| @@ -23,9 +23,6 @@ all: test lint | |||
| dist: | |||
| for ex in $(TOOLS); do cd $$ex && make dist && cd -; done | |||
|
|
|||
| dockerhub: | |||
| for ex in $(TOOLS); do cd $$ex && make dockerhub && cd -; done | |||
There was a problem hiding this comment.
It'd better to alter TOOLS than to drop the dockerhub target, no?
There was a problem hiding this comment.
It is not very easy to use makefile for travis builds. I was trying stuff.
davepuchyr
approved these changes
Feb 5, 2020
This reverts commit 45b8cd1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.