Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cash balance endpoint #18

Merged
merged 7 commits into from
Feb 17, 2020
Merged

Cash balance endpoint #18

merged 7 commits into from
Feb 17, 2020

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Feb 17, 2020

This PR implements cash/balances endpoint for querying /wallets and POST for key queries.

@orkunkl orkunkl marked this pull request as ready for review February 17, 2020 10:17
@davepuchyr davepuchyr self-requested a review February 17, 2020 10:37
@@ -83,6 +83,7 @@ func run(conf Configuration) error {
rt.Handle("/account/domains", &handlers.AccountDomainsHandler{Bns: bnscli})
rt.Handle("/account/accounts", &handlers.AccountAccountsHandler{Bns: bnscli})
rt.Handle("/account/accounts/", &handlers.AccountAccountsDetailHandler{Bns: bnscli})
rt.Handle("/cash/balances", &handlers.CashBalanceHandler{Bns: bnscli})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add /cash/balances to the docs on the endpoint /.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make this code more functional in the future. It is very easy to forget to add this one.

@orkunkl orkunkl merged commit 0c445f1 into master Feb 17, 2020
@orkunkl orkunkl deleted the cash-balance-endpoint branch February 17, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants