Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bio tools (biosnoop, biotop etc) in kernel 5.17 doesn't work #3954

Closed
darkblaze69 opened this issue Apr 23, 2022 · 2 comments
Closed

bio tools (biosnoop, biotop etc) in kernel 5.17 doesn't work #3954

darkblaze69 opened this issue Apr 23, 2022 · 2 comments

Comments

@darkblaze69
Copy link

bio tools (biosnoop, biotop) in kernel 5.17 doesn't work
bcc 0.24

# biotop
/virtual/main.c:78:23: error: no member named 'rq_disk' in 'struct request'
    info.major = req->rq_disk->major;
                 ~~~  ^
/virtual/main.c:79:23: error: no member named 'rq_disk' in 'struct request'
    info.minor = req->rq_disk->first_minor;
                 ~~~  ^
2 errors generated.
Traceback (most recent call last):
  File "/usr/share/bcc/tools/biotop", line 177, in <module>
    b = BPF(text=bpf_text)
  File "/usr/lib/python3.10/site-packages/bcc/__init__.py", line 475, in __init__
    raise Exception("Failed to compile BPF module %s" % (src_file or "<text>"))
Exception: Failed to compile BPF module <text>
@chenhengqi
Copy link
Collaborator

This should be addressed by ddfcc29 .

@darkblaze69
Copy link
Author

thanks

intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 17, 2022
Currently, several BCC ([0]) tools (biosnoop/biostacks/biotop) use
kprobes to blk_account_io_start/blk_account_io_done to implement
their functionalities. This is fragile because the target kernel
functions may be renamed ([1]) or inlined ([2]). So introduces two
new tracepoints for such use cases.

  [0]: https://github.com/iovisor/bcc
  [0]: iovisor/bcc#3954
  [1]: iovisor/bcc#4261

Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Oct 17, 2022
Currently, several BCC ([0]) tools (biosnoop/biostacks/biotop) use
kprobes to blk_account_io_start/blk_account_io_done to implement
their functionalities. This is fragile because the target kernel
functions may be renamed ([1]) or inlined ([2]). So introduces two
new tracepoints for such use cases.

  [0]: https://github.com/iovisor/bcc
  [1]: iovisor/bcc#3954
  [2]: iovisor/bcc#4261

Tested-by: Francis Laniel <flaniel@linux.microsoft.com>
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue May 20, 2023
Currently, several BCC ([0]) tools (biosnoop/biostacks/biotop) use
kprobes to blk_account_io_start/blk_account_io_done to implement
their functionalities. This is fragile because the target kernel
functions may be renamed ([1]) or inlined ([2]). So introduces two
new tracepoints for such use cases.

  [0]: https://github.com/iovisor/bcc
  [1]: iovisor/bcc#3954
  [2]: iovisor/bcc#4261

Tested-by: Francis Laniel <flaniel@linux.microsoft.com>
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
1054009064 pushed a commit to 1054009064/linux that referenced this issue May 25, 2023
Currently, several BCC ([0]) tools (biosnoop/biostacks/biotop) use
kprobes to blk_account_io_start/blk_account_io_done to implement
their functionalities. This is fragile because the target kernel
functions may be renamed ([1]) or inlined ([2]). So introduce two
new tracepoints for such use cases.

  [0]: https://github.com/iovisor/bcc
  [1]: iovisor/bcc#3954
  [2]: iovisor/bcc#4261

Tested-by: Francis Laniel <flaniel@linux.microsoft.com>
Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
Tested-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/r/20230520084057.1467003-1-hengqi.chen@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants