oomkill: Remove trailing newline from output #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhengqi
requested review from
drzaeus77,
goldshtn,
yonghong-song,
4ast,
brendangregg and
davemarchevsky
as code owners
| @@ -78,11 +78,11 @@ static void handle_event(void *ctx, int cpu, void *data, __u32 data_sz) | |||
| strftime(ts, sizeof(ts), "%H:%M:%S", tm); | |||
|
|
|||
| if (n) | |||
| printf("%s Triggered by PID %d (\"%s\"), OOM kill of PID %d (\"%s\"), %lld pages, loadavg: %s\n", | |||
| printf("%s Triggered by PID %d (\"%s\"), OOM kill of PID %d (\"%s\"), %lld pages, loadavg: %s", | |||
There was a problem hiding this comment.
why removing '\n' here? The else branch still has '\n'. it seems '\n' makes sense since different oom's will be in different lines?
There was a problem hiding this comment.
The if branch print /proc/loadavg which has a newline already.
Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
chenhengqi
force-pushed
the
fix-oomkill-output
branch
from
5680e37
to
1d68595
Compare
fengjixuchui
added a commit
to fengjixuchui/bcc
that referenced
this pull request
Aug 8, 2022
Merge pull request iovisor#4147 from chenhengqi/fix-oomkill-output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hengqi Chen chenhengqi@outlook.com