tools/cpudist: Fix warning introduced by recent change #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With iovisor#4131 included, running the tool with -L reports the following warning: /virtual/main.c:57:28: warning: multi-character character constant [-Wmultichar] pid_key_t key = {.id = ' + pid + ', .slot = bpf_log2l(delta)}; ^ /virtual/main.c:57:28: warning: character constant too long for its type 2 warnings generated. The `pid` part should not be treated as string literal. Fix it. Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
chenhengqi
requested review from
brendangregg,
goldshtn and
davemarchevsky
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #4131 included, running the tool with -L reports the following warning:
The
pidpart should not be treated as string literal. Fix it.Signed-off-by: Hengqi Chen chenhengqi@outlook.com