Remove libbcc dependency on llvm headers #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chantra
requested review from
drzaeus77,
yonghong-song,
4ast,
davemarchevsky,
goldshtn and
brendangregg
as code owners
In iovisor#4737 I added depedency on llvm-config.h in order to discover what LLVM version is being used. This was only meant to be used at build time. By adding llvm-config.h in bpf_module.h, a public header of libbcc, I introduced a dependency on llvm-dev to libbcc which is unnecessary. This change removes the include from `bpf_module.h`, which should be enough, and add it to `bpf_module.cc` instead. Fixes iovisor#4997 Signed-off-by: Manu Bretelle <chantr4@gmail.com>
chantra
force-pushed
the
bcc_llvm_config_h
branch
from
4e38827
to
2ed3fa5
Compare
This is essentially reverting iovisor#4921 Signed-off-by: Manu Bretelle <chantr4@gmail.com>
chantra
force-pushed
the
bcc_llvm_config_h
branch
from
2ed3fa5
to
e1fbe4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue brought up in #4997 where llvm-devel was made a requirement for libbcc because of the presence of
llvm-config.hinclude inbpf_module.h.This changes moved the include inside
bpf_module.ccso it does not leak outside of a build requirement.rpm and deb specs were updated, but I was not able to test them.