Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run bpf_conformance using bpf_conformance/tests #168

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

Alan-Jowett
Copy link
Collaborator

The first part of the fix for #163.

This change runs both the tests in ubpf repo and the tests in https://github.com/Alan-Jowett/bpf_conformance.

Signed-off-by: Alan Jowett alanjo@microsoft.com

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
@coveralls
Copy link

coveralls commented Oct 19, 2022

Coverage Status

Coverage increased (+1.0%) to 81.634% when pulling b1b3237 on Alan-Jowett:issue163 into 5c4cb90 on iovisor:main.

Copy link
Collaborator

@matt-gretton-dann matt-gretton-dann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Although I note that there seem to be fewer external tests than internal ones. But this PR isn't about moving completely to the external test framework.

@matt-gretton-dann matt-gretton-dann merged commit 049f603 into iovisor:main Oct 20, 2022
@Alan-Jowett
Copy link
Collaborator Author

Approved. Although I note that there seem to be fewer external tests than internal ones. But this PR isn't about moving completely to the external test framework.

Yes, the bpf_conformance tests don't contain negative tests. The goal is to merge negative tests from this repo + conformance tests from bpf_conformance during the build step to create a single set of tests that can be run that covers both scenarios.

The issue is that the negative tests are very specific to the BPF implementation, so it doesn't make sense to have them in the bpf_conformance repo. On the other hand, they do have value as they test failure paths.

One challenge is that I added support for labels in the assembly in bpf_conformance, but the old python based tests in this repo don't support it.

So we can either:

  1. Retire the python tests.
  2. Update them to support labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants