Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support required .exe suffix for Windows builds #288

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Support required .exe suffix for Windows builds #288

merged 1 commit into from
Jun 13, 2023

Conversation

hawkinsw
Copy link
Collaborator

Windows builds generate executable files with .exe suffix. The ubpf_plugin needs to be addressed accordingly.

@hawkinsw
Support required .exe suffix for Windows builds
102cfc0 
Windows builds generate executable files with .exe suffix. The ubpf_plugin needs to be addressed accordingly.

Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
@hawkinsw
Copy link
Collaborator Author

I thought that I would toss this up. I am not sure how CI/CD differs from my local host, but without these .exe changes I cannot pass ctest. I hope this helps!

@coveralls
Copy link

Coverage Status

coverage: 80.957%. remained the same when pulling 102cfc0 on hawkinsw:windows_exe into d7f7361 on iovisor:main.

@Alan-Jowett Alan-Jowett merged commit 91f1e6f into iovisor:main Jun 13, 2023
@hawkinsw hawkinsw deleted the windows_exe branch June 19, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alan-Jowett Alan-Jowett Alan-Jowett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkinsw @coveralls @Alan-Jowett