Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent division by 0 #396

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Prevent division by 0 #396

merged 2 commits into from
Feb 9, 2024

Conversation

qsr
Copy link

@qsr qsr commented Feb 7, 2024

When checking whether the operand is not 0, one should only look on 32 bits when doing a 32 bits operation.

When checking whether the operand is not 0, one should only look on
32 bits when doing a 32 bits operation.
@Alan-Jowett
Copy link
Collaborator

@qsr Would you object to adding this test to https://github.com/Alan-Jowett/bpf_conformance/tree/main/tests?

This seems like a useful test that might affect other BPF runtimes and if added to the conformance suite we check for this issue in other implementations.

@Alan-Jowett Alan-Jowett enabled auto-merge (squash) February 9, 2024 16:29
@qsr
Copy link
Author

qsr commented Feb 9, 2024

@qsr Would you object to adding this test to https://github.com/Alan-Jowett/bpf_conformance/tree/main/tests?

This seems like a useful test that might affect other BPF runtimes and if added to the conformance suite we check for this issue in other implementations.

No problem: Alan-Jowett/bpf_conformance#198

@coveralls
Copy link

Coverage Status

coverage: 83.35%. remained the same
when pulling 016bed6 on qsr:fix_div32
into 215b8a3 on iovisor:main.

@Alan-Jowett Alan-Jowett merged commit 0276d78 into iovisor:main Feb 9, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants