testdata: Don't modify keys while iterating #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
reviewed
Jan 19, 2021
test_framework/testdata.py
Outdated
| @@ -45,15 +45,18 @@ def read(name): | |||
|
|
|||
|
|
|||
| # Resolve links | |||
| _data = {} | |||
| for k in data: | |||
There was a problem hiding this comment.
Couldn't we use list() here to make a copy of the keys?
Suggested change
| for k in data: | |
| for k in list(data): |
jpsamaroo
force-pushed
the
jps/fix-testdata-iteration
branch
from
3df5aea
to
0112552
Compare
|
2.7 tests are passing on my Travis account, but 3.5 tests are failing for unrelated reasons: https://travis-ci.com/github/jpsamaroo/ubpf/builds/213806623 |
pchaigno
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into errors like
RuntimeError: dictionary keys changed during iterationduring testing; this fixes those for me.