Feature/raw mini #798
Merged
Feature/raw mini #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmessmer
requested changes
Jan 28, 2020
There was a problem hiding this comment.
you need to add raw-mini to cob_supported_robots in order to get checks activated...
please also add a tmp commit with the overlays from https://github.com/ipa320/cob_common/pull/281 and cob_supported_robots so we can verify tests pass....once they pass, the commit can be removed again...
fmessmer
requested changes
Jan 28, 2020
cob_hardware_config/robots/raw-mini/config/base_laser_filter.yaml
Outdated
Show resolved
Hide resolved
cob_hardware_config/robots/raw-mini/config/footprint_observer_params.yaml
Outdated
Show resolved
Hide resolved
fmessmer
force-pushed
the
feature/raw-mini
branch
from
2a5efb1
to
2bae2d2
Compare
|
I rebased and added a roslaunch check....I merged cob_control and cob_common...let's see whether this passes... |
Closed
fmessmer
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retry for #752