Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new project psd option #95

Merged
merged 9 commits into from
Jun 10, 2024
Merged

new project psd option #95

merged 9 commits into from
Jun 10, 2024

Conversation

Huangzizhou
Copy link
Contributor

@Huangzizhou Huangzizhou commented Jun 7, 2024

Description

A new option of projecting the hessian matrix following this repo, instead of clamping the negative eigenvalues to zero, it flips the sign of negative eigenvalues.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test "Project to PSD"

Copy link
Member

@zfergus zfergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! I left a couple of minor comments. I'm happy to merge once they are resolved.

src/ipc/utils/eigen_ext.hpp Outdated Show resolved Hide resolved
src/ipc/utils/eigen_ext.tpp Outdated Show resolved Hide resolved
src/ipc/utils/eigen_ext.tpp Outdated Show resolved Hide resolved
@zfergus
Copy link
Member

zfergus commented Jun 7, 2024

Also, it looks like you need to update the Python bindings. LMK if you need any help with that.

@Huangzizhou Huangzizhou requested a review from zfergus June 7, 2024 23:01
CMakeLists.txt Outdated Show resolved Hide resolved
@zfergus zfergus self-requested a review June 7, 2024 23:23
@zfergus zfergus merged commit 1e38e53 into ipc-sim:main Jun 10, 2024
11 of 13 checks passed
@zfergus zfergus added this to the v1.3.0 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants