This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is PHENOMENAL!!! Love love love it! Will let you take a pass on polish first but ping when want a final review! |
momack2
reviewed
Sep 26, 2019
remove stray #, thanks github
ok ready for review and scheduled for tomorrow (Oct 3) |
momack2
approved these changes
Oct 2, 2019
@doctorrobinson @momack2 I don't have write on this repo, can you merge? |
Thanks for driving this over the finish line while I was out last week! |
hmm I don’t see this on the blog despite the number and the date seemingly being correct? https://circleci.com/gh/ipfs/blog/722 looks good overall though I don’t see the supposed built asset |
I saw the same thing yesterday - I think this is outside of my wheelhouse for things I can fix, maybe @daviddias can help us troubleshoot? |
@autonome got there first with https://github.com/ipfs/blog/issues/312 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sci-Fi Fair blog post. A few notes:
Mainly looking for comments on overall structure and ideas