Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Origin in API calls in Firefox-65.0a1 #623

Merged
merged 2 commits into from
Nov 16, 2018
Merged

fix: Origin in API calls in Firefox-65.0a1 #623

merged 2 commits into from
Nov 16, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented Nov 16, 2018

Closes #622

Context: #622 (comment)

FUN FACT: underlying URL.origin value depends on actual runtime

Node 8:

new URL('moz-extension://0f334731-19e3-42f8-85e2-03dbf50026df/').origin === 'null'

Firefox Firefox-65.0a1:

new URL('moz-extension://0f334731-19e3-42f8-85e2-03dbf50026df/').origin === 'moz-extension://0f334731-19e3-42f8-85e2-03dbf50026df'

Tests and code is value-agnostic, but it is worth being aware that url spec and implementations often diverge around edge cases.

@ghost ghost assigned lidel Nov 16, 2018
@ghost ghost added the status/in-progress In progress label Nov 16, 2018
@lidel lidel merged commit 000e8da into master Nov 16, 2018
@ghost ghost removed the status/in-progress In progress label Nov 16, 2018
@lidel lidel deleted the fix/api-origin-firefox-65.0a1 branch November 16, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lidel lidel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lidel