Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually clarify view-new-window vs download functionality #105

Closed
jessicaschilling opened this issue Feb 4, 2021 · 3 comments · Fixed by #116
Closed

Visually clarify view-new-window vs download functionality #105

jessicaschilling opened this issue Feb 4, 2021 · 3 comments · Fixed by #116
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@jessicaschilling
Copy link
Contributor

Per @autonome note in Jan 2021 hack week:

Be able to view (mime detect) instead of download, with something in URL that indicates that for share links.

This isn't looking like it'll make the time crunch for the week, so capturing in an issue for later inclusion.
Community PRs are more than welcome! :)

@jessicaschilling jessicaschilling added the need/triage Needs initial labeling and prioritization label Feb 4, 2021
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Feb 4, 2021
@lidel
Copy link
Member

lidel commented Feb 4, 2021

I think.. "download" is already implemented on download page.
@autonome @jessicaschilling I made a quick overwiew of how things look like at https://dev.share.ipfs.io/ atm:

Sharing page:

Here we only copy the "view" link, because that makes the most sense when sharing direct links to things that can be viewed in browser (images, PDFs):

2021-02-04--12-50-27

Download page:

Here we have "view" and "download" actions, so receiver can make a decision if they want to save file or view it:

2021-02-04--12-53-07


@autonome
Copy link

autonome commented Feb 4, 2021 via email

@jessicaschilling
Copy link
Contributor Author

Agree it's less than ideal. MUCH better than it was a week ago but will see if we can improve within the boundaries of the hack week - else will open a new issue to reduce confusion.

@jessicaschilling jessicaschilling changed the title View mime-detect instead of download, reflect this in URI Visually clarify view-new-window vs download functionality Feb 4, 2021
lidel added a commit that referenced this issue Feb 5, 2021
@lidel lidel closed this as completed in #116 Feb 5, 2021
lidel added a commit that referenced this issue Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants