Allow users to publish with a generated key + Check minimum version fix

[raucoule1u]

In IPFS class, I added a method "publish" in the inner class Name to allow users to publish with a choosen key.
Furthermore, I marked the method "publish(Optional id, Multihash hash)" as Deprecated because the path is malformed : "name/publish?arg=id&arg=/ipfs/hash" (there are 2 parameters args) and does not comply with the HTTP API.

Since the version 0.4.10, the current algorithm doesn't work anymore because it compares two String objects so "3" > "10". I implemented a new one which compare two integers, recursively.

[Kubuxu]

Please use proper semver lib. IMO it is much better idea.

[ianopolous]

This library needs some love and updating in general I will try and devote some time asap.

[ianopolous]

@Kubuxu I prefer to avoid bringing in binary external dependencies for simple things like this. One major benefit of that approach is that it makes it easy to cross compile this library to JS (which I do elsewhere).

[victorb]

@ianopolous is there a reason you cross-compile this instead of using ipfs/js-ipfs-api?

[ianopolous]

Hi @victorbjelkholm! All of our application logic is written in Java. Originally we had a parallel implementation in JS but it was so much slower to write correctly and error prone. Writing the original in Java and cross compiling lets us move much faster and with much more safety and guarantees. We do have a few interfaces where java code can call out to JS (or Java if it's not running in a browser), but we try to keep those to a minimum.

We are also extremely sensitive to importing random libraries, for security reasons. I have never built js-ipfs-api, but I would guess it brings in 100s of dependencies through npm. All of these would have to be audited in detail in our security audit.

[victorb]

@ianopolous I see. Your guess about the npm dependencies is indeed correct. Thanks for explaining it!

[ianopolous]

@victorbjelkholm No worries! :-)

[raucoule1u]

Does someone plan to do something ? The IPFS version 0.4.10 cannot be used with the API.

[Kubuxu]

@ianopolous is that good to merge?

[ianopolous]

I've just started working on a more general fix. In the meantime you can just use the previous version of IPFS (which was the latest 10 days ago)

[ianopolous]

I've pushed fixes for this, and added a few more methods, to master.

[Kubuxu]

Thanks @ianopolous

[raucoule1u]

@ianopolous Thank you

[raucoule1u]

@ianopolous By the way, could you create a new release and publish it onto the maven repo (which is currently https://jitpack.io/#ipfs/java-ipfs-api) ?

[ianopolous]

@raucoule1u done.

[raucoule1u]

@ianopolous Thank you 😄

[raucoule1u]

@ianopolous I cannot access the Multihash class, so the "cat" function cannot be used.
The dependency is present in pom.xml, so I should be able to access the class.

<dependency>
       <groupId>com.github.multiformats</groupId>
       <artifactId>java-multihash</artifactId>
       <version>v1.1.0</version>
</dependency>

It is the same for the MultiAddress class.

I got this warning :
[WARNING] The POM for com.github.ipfs:java-ipfs-api:jar:v1.1.0 is missing, no dependency information available