-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto build without run build locally #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I wonder if we should lock the referenced actions to a tag or commit rather master so we don't pull in any breaking changes later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bluelovers, just to be safe, let's switch to release versions
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
Thanks @bluelovers (and @lidel for the tweaks), I've merged this and its working well! |
What kind of PR is this?
Select only one to speed up review/approval; i.e., don't lump an addition and a removal into a single PR.
Pre-submit checklist
Please confirm ALL of the following before submitting your PR.
/data
directory instead of the README.md.make build
command following my edits to the/data
directory.Additional details
Is there anything else we should know about this PR?
For new additions: What is your project's current size/reach?
For new additions: What is your project's potential size/reach?
For new additions: How critical is IPFS to your project?
For new additions: What core goal(s) does your project address?
Is anything about IPFS blocking your project?