Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto build without run build locally #340

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Conversation

bluelovers
Copy link
Contributor

What kind of PR is this?

Select only one to speed up review/approval; i.e., don't lump an addition and a removal into a single PR.

  • Adding something new to awesome-ipfs
  • Editing something already listed on awesome-ipfs
  • Removing something from awesome-ipfs
  • Something else (if so, please explain in the "Additional details" section below)

Pre-submit checklist

Please confirm ALL of the following before submitting your PR.

Additional details

Is there anything else we should know about this PR?

For new additions: What is your project's current size/reach?

For new additions: What is your project's potential size/reach?

For new additions: How critical is IPFS to your project?

  • Essential
  • Somewhat critical
  • Useful, but not critical

For new additions: What core goal(s) does your project address?

  • Big-data solutions
  • Freedom from corporate/government interference
  • Data integrity
  • Dev tools or other ways to enable developers
  • Disaster resilience/recovery
  • File storage/retrieval
  • File streaming
  • Permanent archiving
  • Self-sovereign idenity
  • Platforms that utilize consensus, reputation, or incentivization
  • Other (please list)

Is anything about IPFS blocking your project?

@jessicaschilling
Copy link
Contributor

@andrew @lidel - can you please review? Thanks!

Copy link
Contributor

@andrew andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I wonder if we should lock the referenced actions to a tag or commit rather master so we don't pull in any breaking changes later?

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bluelovers, just to be safe, let's switch to release versions

.github/workflows/data.yml Outdated Show resolved Hide resolved
.github/workflows/data.yml Outdated Show resolved Hide resolved
.github/workflows/data.yml Outdated Show resolved Hide resolved
andrew and others added 3 commits April 20, 2020 10:26
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
Co-Authored-By: Marcin Rataj <lidel@lidel.org>
@andrew andrew merged commit bf16315 into ipfs:master Apr 20, 2020
@andrew
Copy link
Contributor

andrew commented Apr 20, 2020

Thanks @bluelovers (and @lidel for the tweaks), I've merged this and its working well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants