Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dependencies on global IPLD registries #328

Open
aschmahmann opened this issue May 31, 2023 · 0 comments
Open

Removing dependencies on global IPLD registries #328

aschmahmann opened this issue May 31, 2023 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@aschmahmann
Copy link
Contributor

While #291 will end up taking care of the special registries in go-ipld-format and go-ipld-legacy there will still be a couple remaining.

  1. The one in boxo/ipld/merkledag
  2. The optional one in go-ipld-prime, but which is used in a lot of places (including transitively in merkledag)

Ultimately these registries have been ok so far as there is only one implementation of a given codec in a single registry, however as soon as that's not true things become more complicated. Furthermore, unlike with the multihash global registry there's code that does type checking against the data that comes out of the registry which leads to breakages as in #291

This is lower priority than #291 since it's not actively causing problems for people, but the more our library tooling propagates the globals as the only option (rather than opting in/out) the more work it'll be to deal with this later.

@aschmahmann aschmahmann added the need/triage Needs initial labeling and prioritization label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant