Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinning/http: PinStatus.Info incorrectly generated #384

Open
aschmahmann opened this issue Aug 26, 2021 · 1 comment
Open

pinning/http: PinStatus.Info incorrectly generated #384

aschmahmann opened this issue Aug 26, 2021 · 1 comment

Comments

@aschmahmann
Copy link
Contributor

PinStatus.Info should be an arbitrary JSON object which is generally represented in Go as map[string]interface{}.

It looks like the tools have some bugs around doing this by default.

OpenAPITools/openapi-generator#3277
OpenAPITools/openapi-generator#518

Also the Meta() wrapper function we wrote incorrectly returns map[string]string as well, so probably I should have noticed this earlier 🤦‍♂️.

cc @whyrusleeping @lidel

@aschmahmann
Copy link
Contributor Author

The linked issues should have descriptions of how to make the code generator behave itself. Note that redoing the code generation will run into OpenAPITools/openapi-generator#7473 and so we'll need to do some of the manual editing to remove the "4XX" checks.

We could also drop the OpenAPITools code generator and either use an alternative or write the client manually, but that might not be worth doing at the moment.

Next step here is probably evaluating if any of the workarounds in the linked issues work and if they don't then we can decide if the next thing is to just drop OpenAPITools as being a pain, or work with them on a patch.

@Jorropo Jorropo changed the title PinStatus.Info incorrectly generated pinning/http: PinStatus.Info incorrectly generated Jun 26, 2023
@Jorropo Jorropo transferred this issue from ipfs/go-pinning-service-http-client Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🥞 Todo
Archived in project
Development

No branches or pull requests

1 participant