Directly importing github.com/ipfs/go-ipfs/repo/config causes dep init and dep ensure to fail

[bonedaddy]

Version Information

go-ipfs version: 0.4.16-dev-2a9de81
Repo version: 7
System version: amd64/linux
Golang version: go1.10.2

Type:

Bug
Relates to #5145 #5147
Possibly related to #5144

Description

When directly importing the config package github.com/ipfs/go-ipfs/repo/config it will cause failures when running dep init or dep ensure, and I believe this is due to an improperly imported dependency of repo/config and is a similar issue/resolution to #5144

Here is an example error message from running dep ensure -v

Solving failure: No versions of github.com/ipfs/go-ipfs met constraints:
	master: "github.com/ipfs/go-ipfs/repo/config" imports "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/mitchellh/go-homedir", which contains malformed code: no package exists at "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/mitchellh/go-homedir"

[whyrusleeping]

I don't know what dep is talking about. @sdboyer any idea whats going on here?

[bonedaddy]

I have a temporary work around, which is updating Gopkg.toml with
ignored = ["github.com/ipfs/go-ipfs/repo/config"]

[sdboyer]

sorry, been occupied! This actually should be resolved in the latest dep, in golang/dep#1921. The issue was that we were basically pretending that Godeps dirs didn't exist. It was unnecessarily harsh to do so, and wasn't really adding anything.

[whyrusleeping]

Ah, great! Thanks for the response, keep hackin away at it :)

[Stebalien]

@postables has this been fixed?

[bonedaddy]

@Stebalien sorry for the late reply! My previous message before this edit is irrelevant as I forgot to update dep before trying again 🤦‍♂️ This issue now seems to be resolved.