Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

CIDv1 Base32 Interop Tests #58

Closed
lidel opened this issue Mar 18, 2019 · 3 comments
Closed

CIDv1 Base32 Interop Tests #58

lidel opened this issue Mar 18, 2019 · 3 comments

Comments

@lidel
Copy link
Member

lidel commented Mar 18, 2019

Migration to CIDv1 (default base32): https://github.com/ipfs/ipfs/issues/337

This is a placeholder issue for a additional tests related to CIDv1 in Base32 that should be added to the interop suite.

@Stebalien (go-ipfs) Do you have anything specific in mind, that we should always check? In the past you mentioned some edge cases related to CIDv1/multihash and blockstore/dht intricacies.

cc @alanshaw (js-ipfs) / ipfs-inactive/interface-js-ipfs-core#444

@Stebalien
Copy link
Member

Mostly just that we need to test adding the content with a CIDv0 CID and retrieving it with a CIDv1 CID, and vice-versa, and between multiple IPFS implementations.

@alanshaw
Copy link
Member

We have CID version tests here already https://github.com/ipfs/interop/blob/master/test/cid-version-agnostic.js - if there’s more we can do then lets use this issue to figure it out!

@alanshaw
Copy link
Member

I assume those are sufficient - please open an new issue with suggestions or a PR if not :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants