Skip to content

add envcfg to rest api #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2018
Merged

add envcfg to rest api #609

merged 1 commit into from
Nov 9, 2018

Conversation

lanzafame
Copy link
Contributor

@hsanjuan Can we get this one through as soon as possible? There is no good way to do this without installing jq on to a container and editing the service.json after ipfs-cluster has been initialised.

@lanzafame
add envcfg to rest api
e115021 
License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
@lanzafame lanzafame added need/review Needs a review P1 High: Likely tackled by core team if no one steps up labels Nov 9, 2018
@lanzafame lanzafame self-assigned this Nov 9, 2018
@lanzafame lanzafame requested a review from hsanjuan November 9, 2018 03:27
@ghost ghost added the status/in-progress In progress label Nov 9, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 64.896% when pulling e115021 on feat/component-env-cfg into 6f72ab2 on master.

@hsanjuan hsanjuan merged commit 77148e5 into master Nov 9, 2018
@hsanjuan hsanjuan deleted the feat/component-env-cfg branch November 9, 2018 12:09
@ghost ghost removed the status/in-progress In progress label Nov 9, 2018
@hsanjuan hsanjuan mentioned this pull request Dec 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees

@lanzafame lanzafame

Labels
need/review Needs a review P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanzafame @coveralls @hsanjuan