Sharness: update configuration files used in sharness #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
This adds support for handling preflight requests in the REST API and fixes currently mostly broken CORS. Before we just let the user add custom response headers to the configuration "headers" key but this is not the best way because CORs headers and requests need special handling and doing it wrong has security implications. Therefore, I have added specific CORS-related configuration options which control CORS behavour. We are forced to change the "headers" defaults and will notify the users about this in the changelog. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
Maintenance License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
added
the
status/blocked
ghost
added
the
Closed
There was a problem hiding this comment.
LGTM. All checks are passed. Travis build that shows pending has also passed, I guess it's a bug on travis.
Will approve this after dependency PR #640 is merged
|
@kishansagathiya you need to click approve to make things green. But I'll merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenance.
Depends on #640 . Last commit only (trivial review).