Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs://example.com in Chromium should produce error #1316

Open
lidel opened this issue Feb 5, 2024 · 0 comments
Open

ipfs://example.com in Chromium should produce error #1316

lidel opened this issue Feb 5, 2024 · 0 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Feb 5, 2024

Problem

Seems we have some magic in Chromium implementation of ipfs:// and ipns:// that makes
ipfs://docs.ipfs.tech correctly redirect to /ipns/ namespace.

While this sounds like useful, it perpetuates incorrect URIs in the wild:
I personally had to reach out to well-meaning authors of some blogposts in the community to fix ipfs//example.com into ipns://example.com because both work in Chromium with Companion, and its easy to miss one letter difference.

Solution

This is specific to Chrimium handling of ipfs://, which still the q= hijack hack described here

Produce intermediate error page which explains that ipfs:// should be only used for immutable identifiers and mutable pointers like cryptographic IPNS rcords and DNSLink domain names should use ipns://.

It should have big green button "Continue to ipns://example.com →" that allows user to get to the correct destination with minimal disruption.

@lidel lidel added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) labels Feb 5, 2024
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

1 participant