Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With DNS Lookup enabled sites that are gateways are redirecting incorrectly. #64

Closed
Kubuxu opened this issue Feb 7, 2016 · 2 comments
Closed

With DNS Lookup enabled sites that are gateways are redirecting incorrectly. #64

Kubuxu opened this issue Feb 7, 2016 · 2 comments
Assignees
@lidel
Labels
kind/bug A bug in existing code (including security flaws) status/blocked Unable to be worked further until needs are met

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Feb 7, 2016

It happened for me with h.ipfs.io but I think you can reproduce it by removing ipfs.io from public gateways list and visiting link like: https://ipfs.io/ipfs/QmTkzDwWqPbnAh5YiV5VwcTLnGdwSNsNTn2aDxdXBFca7D/

The redirect will place you at localhost:8080/ipns/ipfs.io/ipfs/QmTkzDwWqPbnAh5YiV5VwcTLnGdwSNsNTn2aDxdXBFca7D/

I don't know how to fix it right.
@lidel lidel added kind/bug A bug in existing code (including security flaws) status/blocked Unable to be worked further until needs are met labels Feb 7, 2016
@lidel
Copy link
Member

lidel commented Feb 7, 2016

Good catch. I think we could be smarter about detecting IPFS paths (probably need to do #47 for that) and skip the /ipns/<fqdn> segment in such situations.

@lidel lidel self-assigned this Feb 7, 2016
@lidel lidel closed this as completed in 51c7766 Feb 7, 2016
@lidel
Copy link
Member

lidel commented Feb 7, 2016

Will ship a fix in 1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/bug A bug in existing code (including security flaws) status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @Kubuxu