Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peers in v2.7.1 no longer get rendered on the map #1313

Closed
lidel opened this issue Nov 14, 2019 · 10 comments · Fixed by #1334
Closed

Peers in v2.7.1 no longer get rendered on the map #1313

lidel opened this issue Nov 14, 2019 · 10 comments · Fixed by #1334
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Nov 14, 2019

WebUI on the left: v2.6.0, right: v2.7.1
(tested in empty profile)

2019-11-14--20-36-59

I see the same issue in Firefox 70 and Brave 0.70.104
Difference between versions is small (diff), not sure what could cause this, looks like some async code failing silently.

No bandwidth to look into this, but some ideas:

  • perhaps bumping chart.js to v2.9.3 would help?
  • code using p-queue?
@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Nov 14, 2019
@lidel
Copy link
Member Author

lidel commented Nov 14, 2019

@hacdias before digging into this, are you able to reproduce?

@hacdias
Copy link
Member

hacdias commented Nov 14, 2019

It seems ipfs-geoip is failing with the newer js-http-client :'( I didn't dig much (will look tomorrow), but upgrading the version of the http client on the redux bundle seems to have broken this.

@hacdias
Copy link
Member

hacdias commented Nov 15, 2019

@lidel just confirmed and there was a breaking change on v31.0 related to the output of ipfs.object.get and that's what's making this fail. On other news, I can't npm install ipfs-geoip. It just keeps failing and even CI is failing. I will try to get those dependencies updated.

@lidel
Copy link
Member Author

lidel commented Nov 24, 2019

@hacdias i see #69 is merged, what is the next step on the path to fixing this bug?

@hacdias
Copy link
Member

hacdias commented Nov 25, 2019

@lidel a new release of ipfs-geoip with this change ipfs-shipyard/ipfs-geoip@37c6913

@lidel
Copy link
Member Author

lidel commented Nov 28, 2019

@hacdias ipfs-shipyard/ipfs-geoip#69 seems to be merged, do you have permissions to publish new version of ipfs-geoip, or do we need to ping someone?

@hacdias
Copy link
Member

hacdias commented Nov 28, 2019

@lidel we definitely need to ping someone: https://www.npmjs.com/package/ipfs-geoip

@hacdias
Copy link
Member

hacdias commented Nov 28, 2019

/cc @daviddias

@daviddias
Copy link
Member

Just gave you access, @hacdias & @lidel

image

@hacdias
Copy link
Member

hacdias commented Nov 28, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants