This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Allow --cid-version option to be passed to ipfs files add #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
approved these changes
Sep 1, 2017
|
Going to release with the new go-ipfs 0.4.10 support. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply passes options to add command into the query string.
I've had to change
getDagNodeto be able to deal with a CID or a multihash as it's hash argument. This is because when specifying--cid-version=1we get back a CID in the response fromfiles/add, and then the API usesobject/getandobject/datato fetch the content that was just added.