This repository was archived by the owner on Mar 10, 2020. It is now read-only.
feat(breaking change): stream to value on files read #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
hacdias
force-pushed
the
stream-to-value
branch
from
814c8ce to
dbdd13f
Compare
|
The tests seem to be passing (some not related to files.read randomly fail). ping @diasdavid 😄 |
|
@hacdias let's sync up first with all these API changes. We can't simply break the API without understanding why and have a good way to notify users. Spec first out the Files API and then propose the changes. |
|
Sure, makes sense @diasdavid |
hacdias
changed the title
|
@diasdavid the spec is done and merged 😄 |
|
@hacdias can we get CI to pass here? |
|
@diasdavid Travis seems to be passing |
hacdias
force-pushed
the
stream-to-value
branch
from
c5a2a00 to
9cac2f5
Compare
hacdias
force-pushed
the
stream-to-value
branch
from
9cac2f5 to
a3589a0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
streamToValueonfiles.readto return a beautiful Buffer instead of a stream.