Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect provider strategies on initial adds #4311

Closed
whyrusleeping opened this issue Oct 17, 2017 · 1 comment
Closed

respect provider strategies on initial adds #4311

whyrusleeping opened this issue Oct 17, 2017 · 1 comment
Assignees
Labels
topic/provider Topic provider

Comments

@whyrusleeping
Copy link
Member

We have provider strategies that define which content gets provided. However, they are only respected on reprovide, for the initial adding of the content, everything currently gets provided regardless of whether or not it should be given the strategy.

We should rework the providers system to address this issue, moving provides out of the add path should also improve the performance of add.

@whyrusleeping whyrusleeping added the P0 Critical: Tackled by core team ASAP label Oct 17, 2017
@whyrusleeping whyrusleeping added the status/ready Ready to be worked label Oct 17, 2017
@Stebalien Stebalien added status/deferred Conscious decision to pause or backlog status/in-progress In progress needs refinement and removed status/ready Ready to be worked status/deferred Conscious decision to pause or backlog status/in-progress In progress labels Dec 18, 2018
@Stebalien Stebalien removed the P0 Critical: Tackled by core team ASAP label Apr 15, 2019
@momack2 momack2 added this to Needs Refining in ipfs/go-ipfs May 9, 2019
@michaelavila michaelavila added the topic/provider Topic provider label Jun 5, 2019
@michaelavila
Copy link
Contributor

This work is being tracked here: #5774 and references this issue, so I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/provider Topic provider
Projects
No open projects
ipfs/go-ipfs
Needs Refining
Development

Successfully merging a pull request may close this issue.

4 participants