Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datastore tests #4549

Open
magik6k opened this issue Jan 5, 2018 · 4 comments
Open

Add datastore tests #4549

magik6k opened this issue Jan 5, 2018 · 4 comments
Labels
kind/test Testing work topic/badger Topic badger topic/datastore Topic datastore

Comments

@magik6k
Copy link
Member

magik6k commented Jan 5, 2018

Datastores (mostly badger for now) should get some more testing, this can be done in couple of ways:

  • Sharness test running the a test set for a number of datastore configurations
    • Need to get a good set of tests operating on datastore to test well
    • CI won't take much longer to run
  • Running some sharness tests multiple times for different configs
    • Tests will take more time to run
    • Should stress the datastores rather well
  • Running all sharness tests with different configs
    • Probably overkill
    • Tests will take forever to run
@magik6k magik6k added the kind/test Testing work label Jan 5, 2018
@whyrusleeping
Copy link
Member

Some things for the list of things to test:

  • garbage collection actually frees up space
  • reasonable errors when running out of disk space (no corruption)
  • putting and deleting the same value back and forth many times doesnt cause problems

@schomatis
Copy link
Contributor

I'm assigning (temporarily) this issue to myself while I prepare some tests for the Badger implementation, you could guide me to structure those tests in a way that they may be re-utilized in the future for the generic datastore interface. (Sometimes that won't be possible as some tests need to interact directly with badger-specific settings.)

@schomatis schomatis self-assigned this May 3, 2018
@schomatis schomatis added topic/datastore Topic datastore topic/badger Topic badger labels May 3, 2018
@schomatis
Copy link
Contributor

schomatis commented May 22, 2018

@magik6k Do you know of any sharness test I could use as a base for the datastore tests?

@magik6k
Copy link
Member Author

magik6k commented May 22, 2018

For some relevant tests I'd start with 40-add-and-cat, 45-ls, 50-block, 53-dag, 80-repo and 81-repo-gc-auto.

Optimally we'd be able to tell sharness/make to re-run some tests with different datastore/profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Testing work topic/badger Topic badger topic/datastore Topic datastore
Projects
None yet
Development

No branches or pull requests

3 participants