Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle symlinks on windows #4906

Open
Stebalien opened this issue Apr 2, 2018 · 5 comments
Open

Handle symlinks on windows #4906

Stebalien opened this issue Apr 2, 2018 · 5 comments
Labels
topic/windows Windows specific

Comments

@Stebalien
Copy link
Member

Now that @whyrusleeping added symlink support to tar-utils, fetching something with a symlink in it fails instead of succeeding (when it shouldn't). However, ideally, we'd do something better than simply fail...

@djdv djdv self-assigned this Apr 2, 2018
@djdv
Copy link
Contributor

djdv commented Apr 2, 2018

Without proper access rights a user can't create a symlink. We can see if we have that right and make decisions around that. Either fail with a message alerting the user to enable symlink creation for that user, or use a secondary method such as resolving the link's target and copying the contents (with or without some depth limit to deal with recursive links).

If we decide to alert the user, we can write a section in the Windows build document that helps them to enable symlink creation for their account and then link it to them.

@djdv
Copy link
Contributor

djdv commented Apr 6, 2018

@Stebalien
Please take a look over here whyrusleeping/tar-utils#2 (comment)

@djdv djdv mentioned this issue Apr 6, 2018
9 tasks
@Stebalien
Copy link
Member Author

Is there anything left here?

@djdv
Copy link
Contributor

djdv commented May 7, 2019

We have the ability to add and traverse links while adding, but we don't have a strategy merged for extracting links.
The major problem is that on Windows, we need to know what the symlinks target type is, at creation time. But we have no way to know that.
The other issue is extracting files from IPFS that have platform illegal names.
We have to decide on the expected behavior for platform specific problems such as these, and/or a way to configure that.

Context: #4956 (comment)

@Stebalien
Copy link
Member Author

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/windows Windows specific
Projects
None yet
Development

No branches or pull requests

2 participants