Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Output announced multiaddresses found after start-up #9096

Open
3 tasks done
Winterhuman opened this issue Jul 6, 2022 · 3 comments
Open
3 tasks done

daemon: Output announced multiaddresses found after start-up #9096

Winterhuman opened this issue Jul 6, 2022 · 3 comments
Labels
kind/stale P3 Low: Not priority right now

Comments

@Winterhuman
Copy link
Contributor

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

(This is a smaller issue that continues from #9043, and a ipfs daemon equivalent to ipfs/ipfs-webui#1964)

Currently, ipfs daemon prints Swarm announcing for the initial, local multiaddresses. However, when using RelayClient, public multiaddresses aren't found until after Daemon is Ready and so are never reported.

Ideally, ipfs daemon's output should report additional Swarm announcing messages for multiaddresses found after it reports Daemon is ready.

@Winterhuman Winterhuman added the kind/enhancement A net-new feature or improvement to an existing feature label Jul 6, 2022
@BigLep
Copy link
Contributor

BigLep commented Jul 22, 2022

2022-07-22 conversation:

In this scenario, addresses are going to be influx.

Options:

  1. Don't print out anything in ipfs daemson (stopping this may break sharness tests, which isn't good, but is the unfortunate state of the affairs)
  2. Print everytime address changes (not a priority for maintainers currently)
  3. Add extra log statement in ipfs daemon that addresses are in flux and use ipfs id. (cheapest way to give users a hint. This is where we'd want to invest.)

@Winterhuman : could you take on doing #3? It would be a small log statement to add.

@BigLep BigLep added P3 Low: Not priority right now need/author-input Needs input from the original author and removed kind/enhancement A net-new feature or improvement to an existing feature labels Jul 22, 2022
@Winterhuman
Copy link
Contributor Author

@BigLep I'm afraid I have scarce little knowledge of coding (I'm a docs/spec person at best), someone else will have to handle this unfortunately

@github-actions
Copy link

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

@Jorropo Jorropo removed the need/author-input Needs input from the original author label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/stale P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

3 participants