Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved batch processing #37

Merged
merged 14 commits into from
Dec 21, 2020
Merged

Improved batch processing #37

merged 14 commits into from
Dec 21, 2020

Conversation

UmanShahzad
Copy link
Contributor

Closes #33
Closes #35

@UmanShahzad UmanShahzad self-assigned this Dec 16, 2020
@UmanShahzad
Copy link
Contributor Author

Basic improvements to the batch processor work now, specifically that chunking happens and so there is no real limit to the input list size.

What's next:

  • Add an option which if turned on, a 429 status on one of the responses doesn't discard all successful responses so far.
  • Add a scaling and hard timeout, and options to override them.

From this I realized we can create an iterator-based batch function, so filed #38. The existing non-iterators can be refactored to reuse the iterator later by consuming all of the iterator at once before returning.

@UmanShahzad UmanShahzad changed the title [WIP] Improved batch processing Improved batch processing Dec 21, 2020
@UmanShahzad UmanShahzad merged commit e229f52 into master Dec 21, 2020
@UmanShahzad UmanShahzad deleted the uman/better-batch-ops branch December 21, 2020 16:17
Copy link

@a7mad-0 a7mad-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahmad//aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants