Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add car inspect command to cmd pkg #320

Merged
merged 3 commits into from
Jul 15, 2022
Merged

feat: add car inspect command to cmd pkg #320

merged 3 commits into from
Jul 15, 2022

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 12, 2022

I'm not sure if the replaces in go.mod are going to be a problem here but they seem appropriate to help building it consistently without needing to release then update here afterward

@rvagg rvagg requested a review from masih July 12, 2022 05:02
@rvagg rvagg self-assigned this Jul 12, 2022
masih
masih approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vote would be to not use replace directive or move it to a separate PR for further discussion. Otherwise LGTM 👍

cmd/go.mod Outdated Show resolved Hide resolved
@rvagg rvagg merged commit 3264624 into master Jul 15, 2022
@rvagg rvagg deleted the rvagg/cmd-inspect branch July 15, 2022 01:04
rvagg added a commit that referenced this pull request Aug 12, 2022
@rvagg
feat: add car inspect command to cmd pkg (#320)
d321c7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott left review comments

@masih masih masih approved these changes

Assignees

@rvagg rvagg

Labels
None yet
Projects
IPLD team's weekly tracker
Status: 🎉 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvagg @masih @willscott