fix: ReadHeader return value mismatch #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
reviewed
Jun 3, 2021
|
pulled in #74 to resolve codecov errors, also fixed a few lint/vet/deprecation errors it throws up |
marten-seemann
approved these changes
Jun 3, 2021
mvdan
approved these changes
Jun 3, 2021
Merged
masih
approved these changes
Jun 3, 2021
masih
added a commit
that referenced
this pull request
Jun 10, 2021
Since we are releasing a new major version, define a new go module for the CAR v2 implementation, following the recommendations here: - https://blog.golang.org/v2-go-modules The module is versioned as go 1.15 to maintain compatibility as pointed out by comment here: - #75 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./car/ tends to get overlooked cause it has no tests in it, but the new Actions errors on problems in there now thankfully, see #74