feat: use package-table #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
|
Ping @diasdavid |
daviddias
suggested changes
Aug 22, 2018
README.md
Outdated
| | [`ipld-cbor`](//github.com/ipfs/go-ipld-cbor) | [](https://travis-ci.org/ipfs/go-ipld-cbor) | [](https://ci.ipfs.team/job/ipfs/job/go-ipld-cbor/job/master/) | [](https://codecov.io/gh/ipfs/go-ipld-cbor) | | ||
| | [`ipld-git`](//github.com/ipfs/go-ipld-git) | [](https://travis-ci.org/ipfs/go-ipld-git) | [](https://ci.ipfs.team/job/ipfs/job/go-ipld-git/job/master/) | [](https://codecov.io/gh/ipfs/go-ipld-git) | | ||
| | [`ipld-eth`](//github.com/ipfs/go-ipld-eth) | [](https://travis-ci.org/ipfs/go-ipld-eth) | [](https://ci.ipfs.team/job/ipfs/job/go-ipld-eth/job/master/) | [](https://codecov.io/gh/ipfs/go-ipld-eth) | | ||
| | [`ipld-btc`](//github.com/ipfs/go-ipld-btc) | [](https://travis-ci.org/ipfs/go-ipld-btc) | [](https://ci.ipfs.team/job/ipfs/job/go-ipld-btc/job/master/) | [](https://codecov.io/gh/ipfs/go-ipld-btc) | |
There was a problem hiding this comment.
For the ones that there is no CI, can you replace the wonky badge by a N/A?
There was a problem hiding this comment.
Maybe we could do that on package-table. There must be APIs for that :)
There was a problem hiding this comment.
yep. In fact, you just have to do a HEAD request for the image and if it returns a 404, then there is no CI running there :)
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
daviddias
approved these changes
Aug 23, 2018
|
@Stebalien can you review this ASAP? should take you less than 5 mins. |
Stebalien
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com