-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export a version from the writer #161
Comments
3 tasks
Yeah, strictly only v1 and as yet I've not seen a compelling reason to do v2 in JS except for if someone wants to make a blockstore; although I think web3.storage has an implementation that uses v2 with indexes for something to do with unixfs paths. Feel free to add a |
achingbrain
added a commit
that referenced
this issue
Feb 21, 2024
The `version()` method retrieves the version number from the underlying encoder. Fixes #161
achingbrain
added a commit
that referenced
this issue
Feb 22, 2024
The `version()` method retrieves the version number from the underlying encoder. Fixes #161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From what I can tell, this module will only create v1 CAR files and it doesn't provide a method to obtain the version of the file it's creating - please let me know if I've missed something obvious.
When returning a CAR file from an HTTP Gateway the spec says the
Content-Type
header should include the version number, e.g:It'd be great if we could hand that off to the writer, to reduce the chance of it getting messed up, something like:
The text was updated successfully, but these errors were encountered: