Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

feat: use package-table vs custom script #144

Merged
merged 2 commits into from
Aug 22, 2018
Merged

feat: use package-table vs custom script #144

merged 2 commits into from
Aug 22, 2018

Conversation

daviddias
Copy link
Member

No description provided.

@@ -120,12 +120,8 @@ const Resolver = new Resolver(<ipfs-block-service instance>)

## Packages

Listing of dependencies from the IPFS ecosystem.
Listing of dependencies from the IPLD ecosystem.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment on how this table is generated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. See below

@vmx
Copy link
Member

vmx commented Aug 22, 2018

@jonahweissman This change might be of interest of you as you implemented the original table.

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files           1        1           
  Lines         194      194           
=======================================
  Hits          172      172           
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1949894...8429d10. Read the comment docs.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vmx vmx merged commit f493902 into master Aug 22, 2018
@vmx vmx deleted the package-table branch August 22, 2018 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants